feat: Update span interface to add a new function which will return span id

[stellarhuman]

Description

Added a way to directly get the spanId, from the span that is created.

[thugrock7]

do we expect this value to be not null everytime or do need to something like

if (s.Span.SpanContext().SpanID().HasSpanID()) {
   s.Span.SpanContext().SpanID().String()
 }
 return ""

[stellarhuman]

idts, if a span doest exist, you should always be able to call this method

[varkey98]

this should be fine. String's null value is empty string in golang. As long as it returns a string, we dont have to check here explicitly

[thugrock7]

use assertions instead. ex: assert.Equal(t, 8, SpanIDNoOfBytes)

[varkey98]

Do we really need this change here in goagent? We can simply do this in TPA if this is the route you want to go

	spanCtx := trace.SpanContextFromContext(ctx)
	if spanCtx.HasTraceID() {
		fmt.Println(spanCtx.TraceID().String())
	}

	if spanCtx.HasSpanID() {
		fmt.Println(spanCtx.SpanID().String())
	}

Adding it here is not really required imo

[thugrock7]

Yes, functionally we can get this done using trace.SpanContextFromContext(ctx) as well, but thinking about this logically , as span ID is property of span, I simply want to do something like GetSpanID() on span to fetch this ID rather than knowing internals to call spanContext ourselves and get this done where ever span ID is required .

[varkey98]

Yes, functionally we can get this done using trace.SpanContextFromContext(ctx) as well, but thinking about this logically , as span ID is property of span, I simply want to do something like GetSpanID() on span to fetch this ID rather than knowing internals to call spanContext ourselves and get this done where ever span ID is required .

Fair enough, but I'm not sure which is better

[thugrock7]

your inputs here @ryanericson ?

[ryanericson]

Yes, functionally we can get this done using trace.SpanContextFromContext(ctx) as well, but thinking about this logically , as span ID is property of span, I simply want to do something like GetSpanID() on span to fetch this ID rather than knowing internals to call spanContext ourselves and get this done where ever span ID is required .

Fair enough, but I'm not sure which is better

Ah I see what @varkey98 found which is kind of equivalent. But I agree with @thugrock7, just exposing it in our SDK is cleaner and I don't see any harm.

[varkey98]

LGTM

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@9789c3a). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
sdk/internal/mock/span.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage        ?   61.16%           
=======================================
  Files           ?       59           
  Lines           ?     2688           
  Branches        ?        0           
=======================================
  Hits            ?     1644           
  Misses          ?      964           
  Partials        ?       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[thugrock7]

Merging this, as @stellarhuman needs to use these changes on TPA side PR and want this PR to be included in this month release.