improve: add missing return types to Container::get() and Container::make()
#307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `: mixed` return type to get() and make() methods. This fixes incorrect facade docblock generation (via hypervel/facade-documenter) which defaults to `void` when no return type is declared, causing IDE errors when using App::get() to resolve services.
albertcht
changed the title
Container::get() and Container::make()Container::get() and Container::make()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
: mixedreturn type toget()andmake()methods. This fixes incorrect facade docblock generation (viahypervel/facade-documenter) which defaults tovoidwhen no return type is declared, causing IDE errors when usingApp::get()to resolve services.