Conversation
There was a problem hiding this comment.
Pull request overview
This pull request removes internal Node.js and yarn setup from the starship-action, requiring users to explicitly configure Node.js in their workflows before using the action. The change simplifies the action by delegating environment setup to users while switching from yarn to npm for installing the @starship-ci/cli package.
Changes:
- Removes internal
actions/setup-nodeand yarn setup steps from action.yaml - Updates the CLI installation command from
yarn global addtonpm install -g - Adds explicit Node.js setup (v24) to all test workflows and README example
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| action.yaml | Removes Node.js/yarn setup steps and temporary file creation; switches CLI installation to npm |
| README.md | Updates example workflow to include explicit Node.js v24 setup requirement |
| .github/workflows/test.yaml | Adds Node.js v24 setup to all three test jobs to support the new architecture |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: "24" |
There was a problem hiding this comment.
Trailing whitespace detected at the end of this line. Consider removing it to maintain consistent code formatting.
| node-version: "24" | |
| node-version: "24" |
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: "24" |
There was a problem hiding this comment.
Trailing whitespace detected at the end of this line. Consider removing it to maintain consistent code formatting.
| node-version: "24" | |
| node-version: "24" |
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: "24" |
There was a problem hiding this comment.
Trailing whitespace detected at the end of this line. Consider removing it to maintain consistent code formatting.
| node-version: "24" | |
| node-version: "24" |
Description
The current
starship-actioninternally usesactions/setup-nodeand yarn to install@starship-ci/cli. This forces a specific Node.js version and package manager (yarn), which may conflict with user project configurations.Since
@starship-ci/clican be executed vianpx, this PR removes the Node.js/yarn setup and relies on the runner's pre-installed environment instead.Changes
actions/setup-nodeand yarn installation steps