Include document info when creating page notes via experimental button#7477
Merged
Include document info when creating page notes via experimental button#7477
Conversation
f170e27 to
880b2c7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7477 +/- ##
=======================================
Coverage 99.50% 99.50%
=======================================
Files 271 271
Lines 11017 11028 +11
Branches 2655 2656 +1
=======================================
+ Hits 10962 10973 +11
Misses 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
880b2c7 to
ec5eb13
Compare
acelaya
pushed a commit
that referenced
this pull request
Dec 19, 2025
acelaya
pushed a commit
that referenced
this pull request
Dec 19, 2025
acelaya
pushed a commit
that referenced
this pull request
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have discovered that page notes created via the button rendered when
enableExperimentalNewNoteButtonistrue, do not include the document metadata, since the logic is not triggered in the guest document, as it happens with the regular page notes button or annotations and highlights created from the adder.This PR adds a new RPC message that can be used for the sidebar to request the guest document info on demand, allowing those page notes to properly include the document metadata.
Test steps
POST http://localhost:5000/api/annotationscall, and verify it includes alldocumentmetadata.mainbranch, thedocumentwill be "empty"TODO