Draft
Conversation
spikespaz
added
enhancement
5 tasks
The `monitors` definitions can now support variables defined here: <https://wiki.hypr.land/Configuring/Monitors/#monitor-v2> FIXME: There's a problem with using `freeformType` and `mkRenamedOptionModule` in the same submodule type: because any arbitrary attributes are accepted by the `freeformType`, the renamed option warnings will never be triggered, and never shown. However, the old attribute will still automatically be replaced by the new one.
spikespaz
force-pushed
the
u/jacob/monitorv2-freeform-options
branch
from
ce73f9b to
a1d06a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
monitorsdefinitions can now support variables defined here: https://wiki.hypr.land/Configuring/Monitors/#monitor-v2FIXME: There's a problem with using
freeformTypeandmkRenamedOptionModulein the same submodule type: because any arbitrary attributes are accepted by thefreeformType, the renamed option warnings will never be triggered, and never shown. However, the old attribute will still automatically be replaced by the new one.