feat: Added wallpaper rotation and mirroring#279
Open
lucaschristiansson wants to merge 7 commits intohyprwm:mainfrom
Open
feat: Added wallpaper rotation and mirroring#279lucaschristiansson wants to merge 7 commits intohyprwm:mainfrom
lucaschristiansson wants to merge 7 commits intohyprwm:mainfrom
Conversation
lucaschristiansson
changed the title
lucaschristiansson
changed the title
vaxerski
reviewed
Sep 27, 2025
vaxerski
reviewed
Sep 29, 2025
| const std::string COMMAND = C; | ||
| const std::string VALUE = V; | ||
| Hyprlang::CParseResult result; | ||
| Hyprutils::String::CVarList args(VALUE, 3, ',', true); |
Member
There was a problem hiding this comment.
add a using namepsace Hyprutils::String at the top to avoid this
also this can be a CConstVarList because you arent editing anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the entire wallpaper rotation implementation from #276
Following advice from @vaxerski, the rotation now aligns with the monitor rotation in hyprland.
I also copied and used the previous monitor rotation documentation from hyprland for this implementation.
This refactor is compatable with all existing configurations and no changes are required for current setups.