chore(server): check task and context ownership for a2a proxy requests #1356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jezekra1
force-pushed
the
a2a-proxy-check-ownership
branch
4 times, most recently
from
1d62357 to
be7f914
Compare
jezekra1
commented
Oct 21, 2025
| assert response.status_code == 404 # FastAPI's default for no route | ||
|
|
||
|
|
||
| @pytest.mark.skip(reason="Extended agent card is not supported at the moment. # TODO") |
Collaborator
Author
There was a problem hiding this comment.
we lost a bunch of these features, probably most people don't need them so let's add them on request
jezekra1
force-pushed
the
a2a-proxy-check-ownership
branch
from
be7f914 to
488dfd8
Compare
pilartomas
approved these changes
Oct 29, 2025
| "preferred_transport": TransportProtocol.jsonrpc, | ||
| "url": proxy_base, | ||
| "additional_interfaces": [ | ||
| AgentInterface(transport=TransportProtocol.http_json, url=urljoin(proxy_base, "http")), |
Contributor
There was a problem hiding this comment.
Why not use a2a_proxy_http_transport.__name__ ?
Signed-off-by: Radek Ježek <[email protected]>
jezekra1
force-pushed
the
a2a-proxy-check-ownership
branch
from
488dfd8 to
3b6034a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.