-
Notifications
You must be signed in to change notification settings - Fork 137
feat(ui): add single select component to form extension #1359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @PetrBulanek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Signed-off-by: Petr Bulánek <[email protected]>
e928dad to
2e74197
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new SingleSelectField component to the form extension, enabling single-choice selection from a list of options. The changes are comprehensive, spanning the Python SDK, TypeScript SDK, UI components, styling, and documentation. The implementation is solid, with backend validation for the default value. I've identified a couple of areas for improvement: adding similar validation to the TypeScript schema for consistency and fixing an error in the documentation example for the new field. Overall, this is a great addition.
Signed-off-by: Petr Bulánek <[email protected]>
|
@JanPokorny Can you please take a look at this too, see if it makes sense, and can we merge it? :-) |
Closes: #1338