-
Notifications
You must be signed in to change notification settings - Fork 137
fix(ci): prefer managed python in uv #1368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): prefer managed python in uv #1368
Conversation
Signed-off-by: Jan Pokorný <[email protected]>
Summary of ChangesHello @JanPokorny, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Python environment preference for Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request aims to configure the environment to prefer managed Python installations when using the uv tool. This is achieved by removing the UV_PYTHON_PREFERENCE=only-system environment variable setting from the GitHub Actions workflow file and adding UV_PYTHON_PREFERENCE = "only-managed" to the mise.toml file. This change ensures that uv uses the managed Python environment, potentially improving consistency and reliability across different environments.
| shell: bash | ||
| run: | | ||
| echo "UV_FROZEN=true" >> $GITHUB_ENV | ||
| echo "UV_PYTHON_PREFERENCE=only-system" >> $GITHUB_ENV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this line enforces the preference for managed Python environments, aligning with the pull request's objective. Ensure this change doesn't negatively impact any workflows that rely on the system Python. Consider documenting why this change is being made to avoid confusion in the future.
If there are no workflows that rely on the system Python, then this change is correct.
| [env] | ||
| UV_PYTHON_PREFERENCE = "only-managed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This addition sets the UV_PYTHON_PREFERENCE environment variable to only-managed, ensuring that uv prefers managed Python environments. This aligns with the pull request's objective. Ensure that this setting is compatible with all the tasks and environments where uv is used.
Consider adding a comment explaining why this setting is being enforced.
Signed-off-by: Jan Pokorný <[email protected]>
No description provided.