Skip to content

Conversation

@JanPokorny
Copy link
Collaborator

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @JanPokorny, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Python environment preference for uv within the project's CI setup. It transitions from an implicit reliance on system Python, sometimes overridden in specific CI steps, to a clear and consistent preference for Python versions managed by mise. This change aims to enhance build reproducibility and consistency across development and CI environments by ensuring uv utilizes explicitly defined Python environments.

Highlights

  • Python Preference Configuration: The project's configuration for uv's Python preference has been updated to explicitly favor managed Python environments over system-wide installations.
  • CI Workflow Adjustment: A previous override in the GitHub Actions setup that forced uv to use only-system Python has been removed, aligning the CI behavior with the new global preference for managed Python.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request aims to configure the environment to prefer managed Python installations when using the uv tool. This is achieved by removing the UV_PYTHON_PREFERENCE=only-system environment variable setting from the GitHub Actions workflow file and adding UV_PYTHON_PREFERENCE = "only-managed" to the mise.toml file. This change ensures that uv uses the managed Python environment, potentially improving consistency and reliability across different environments.

shell: bash
run: |
echo "UV_FROZEN=true" >> $GITHUB_ENV
echo "UV_PYTHON_PREFERENCE=only-system" >> $GITHUB_ENV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Removing this line enforces the preference for managed Python environments, aligning with the pull request's objective. Ensure this change doesn't negatively impact any workflows that rely on the system Python. Consider documenting why this change is being made to avoid confusion in the future.

If there are no workflows that rely on the system Python, then this change is correct.

Comment on lines +33 to +34
[env]
UV_PYTHON_PREFERENCE = "only-managed"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This addition sets the UV_PYTHON_PREFERENCE environment variable to only-managed, ensuring that uv prefers managed Python environments. This aligns with the pull request's objective. Ensure that this setting is compatible with all the tasks and environments where uv is used.

Consider adding a comment explaining why this setting is being enforced.

@JanPokorny JanPokorny merged commit 513406c into main Oct 22, 2025
8 checks passed
@JanPokorny JanPokorny deleted the janpokorny/fix-ci-prefer-managed-python-in-uv branch October 22, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants