-
Notifications
You must be signed in to change notification settings - Fork 137
feat(server): add optional provider_id reference to contexts #1370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @jezekra1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the context management system by allowing contexts to be optionally linked to a specific provider. This enables better organization and filtering of contexts based on their origin or associated service, improving the overall flexibility and utility of the context feature. The changes span the entire stack, from the database schema and API to the SDK and comprehensive testing. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces an optional provider_id to the context model and related functionalities. This allows contexts to be associated with specific providers, enabling filtering and better organization of contexts. The changes include modifications to the data models, API schemas, service layer, persistence layer, and e2e tests to accommodate the new provider_id field. I have identified a few areas where improvements can be made to ensure code quality and clarity.
| async def create( | ||
| *, | ||
| metadata: Metadata | None = None, | ||
| provider_id: str | None = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tell me, where else in this file is Optional type hint?
apps/beeai-server/src/beeai_server/infrastructure/persistence/repositories/context.py
Show resolved
Hide resolved
apps/beeai-server/src/beeai_server/infrastructure/persistence/repositories/context.py
Show resolved
Hide resolved
75cde5b to
052d331
Compare
Signed-off-by: Radek Ježek <[email protected]>
052d331 to
f94fc22
Compare
No description provided.