-
Notifications
You must be signed in to change notification settings - Fork 139
feat(ui): render markdown in API error messages #1593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+79
−34
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
15c217c
feat(ui): render markdown in API error messages
kapetr af83694
fixup! refactor MarkdownContent based on review comments
kapetr c66ad6e
fixup! review comments
kapetr 9cb68f1
feat(ui): use LineClamp component for toast message content
PetrBulanek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
apps/agentstack-ui/src/modules/runs/components/ChatMarkdownContent/ChatMarkdownContent.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /** | ||
| * Copyright 2025 © BeeAI a Series of LF Projects, LLC | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import type { JSX } from 'react'; | ||
| import { useMemo } from 'react'; | ||
| import type { Components } from 'react-markdown'; | ||
|
|
||
| import { MarkdownContent } from '#components/MarkdownContent/MarkdownContent.tsx'; | ||
| import type { UISourcePart } from '#modules/messages/types.ts'; | ||
| import type { CitationLinkBaseProps } from '#modules/runs/components/ChatMarkdownContent/CitationLink/CitationLink.tsx'; | ||
| import { CitationLink } from '#modules/runs/components/ChatMarkdownContent/CitationLink/CitationLink.tsx'; | ||
|
|
||
| import { remarkCitationLink } from './CitationLink/remarkCitationLink'; | ||
|
|
||
| interface Props { | ||
| codeBlocksExpanded?: boolean; | ||
| sources?: UISourcePart[]; | ||
| children?: string; | ||
| className?: string; | ||
| } | ||
kapetr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| export function ChatMarkdownContent({ sources, ...props }: Props) { | ||
| const components: ChatComponents = useMemo( | ||
| () => ({ | ||
| citationLink: ({ ...props }) => <CitationLink {...props} sources={sources} />, | ||
| }), | ||
| [sources], | ||
| ); | ||
|
|
||
| return <MarkdownContent {...props} components={components} remarkPlugins={remarkPlugins} />; | ||
| } | ||
|
|
||
| const remarkPlugins = [remarkCitationLink]; | ||
kapetr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| export interface ChatComponents extends Components { | ||
| citationLink?: (props: CitationLinkBaseProps) => JSX.Element; | ||
| } | ||
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.