fix(tests): skip heavy docling e2e test

[jezekra1]

Summary

test if this helps

Documentation

• No Docs Needed:

[gemini-code-assist]

Summary of Changes

Hello @jezekra1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to optimize the test pipeline by temporarily disabling the resource-intensive "docling" component and its associated end-to-end test. This change is intended to alleviate performance issues or resource constraints during test runs. Additionally, it includes an enhancement to existing plain text extraction tests by adding verification for extraction deletion.

Highlights

• Docling Service Temporarily Disabled: The docling.enabled flag has been commented out in apps/agentstack-server/tasks.toml for the agentstack:start command, with a TODO indicating it's too heavy for current pipeline resources.
• Heavy E2E Test Skipped: The test_text_extraction_pdf_workflow e2e test in apps/agentstack-server/tests/e2e/routes/test_files.py is now skipped using @pytest.mark.skip, explicitly stating that Docling is temporarily disabled due to its heavy image size.
• Extraction Deletion Tests Added: New subtests have been introduced in test_text_extraction_plain_text_workflow to ensure proper deletion of text extractions and verify their non-existence after deletion.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request disables a resource-intensive end-to-end test related to 'docling' to improve pipeline performance. The changes correctly disable the feature in the test environment configuration and skip the corresponding test case in the suite. My review includes a suggestion for an unrelated change in the PR, which adds cleanup logic to another test. I've recommended extending this to also clean up the file resource created during the test, ensuring better test hygiene and preventing potential resource leaks.

[gemini-code-assist]

It's great that you've added cleanup for the text extraction. However, the test also creates a file which is not being deleted at the end. This could lead to resource leaks in the test environment. Other tests in this file, like test_file_extraction_context_isolation, clean up both the extraction and the file. It would be best to add cleanup for the file as well to ensure resources are properly released.

Suggested change

	with subtests.test("delete extraction"):
	await file.delete_extraction()
	with (
	subtests.test("verify extraction deleted"),
	pytest.raises(httpx.HTTPStatusError, match="404 Not Found"),
	):
	_ = await file.get_extraction()
	with subtests.test("delete extraction"):
	await file.delete_extraction()
	with (
	subtests.test("verify extraction deleted"),
	pytest.raises(httpx.HTTPStatusError, match="404 Not Found"),
	):
	_ = await file.get_extraction()
	with subtests.test("delete file"):
	await file.delete()
	with (
	subtests.test("verify file deleted"),
	pytest.raises(httpx.HTTPStatusError, match="404 Not Found"),
	):
	_ = await File.get(file.id)