Skip to content

feat(agentstack-server): support stdio mcp #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JanPokorny merged 15 commits into from
Dec 2, 2025
Merged

feat(agentstack-server): support stdio mcp #1606

JanPokorny merged 15 commits into from
Dec 2, 2025

Conversation

@JanPokorny
Copy link
Collaborator

@JanPokorny JanPokorny commented Nov 19, 2025 •
edited by matoushavlena
Loading

Summary

Refs: #1604

Linked Issues

Documentation

  • No Docs Needed:

If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.

@JanPokorny JanPokorny force-pushed the janpokorny/feat-agentstack-server-support-stdio-mcp branch 6 times, most recently from e72a5b7 to 041c7f5 Compare November 21, 2025 15:39
@pilartomas pilartomas mentioned this pull request Nov 24, 2025
Merged
1 task
@JanPokorny JanPokorny force-pushed the janpokorny/feat-agentstack-server-support-stdio-mcp branch 10 times, most recently from be9ff2a to fef9909 Compare November 26, 2025 14:38
@JanPokorny
Copy link
Collaborator Author

JanPokorny commented Nov 28, 2025 •
edited
Loading

TODO in this PR:

  • Working implementation using pods with supergateway sidecar
  • Split OAuth (external) and Kubernetes (internal) MCP server logic into separate services
  • Start managed MCP server on "connect", not "create"
  • Revise connect/disconnect/probe logic to be applicable to both
  • Review feedback
  • Propagate bearer token to env vars of provider
  • Docs

For future PR:

  • Allow http MCP servers to be managed too
  • Allow running MCP servers in an external cluster (like provider builds)

@JanPokorny
feat: support stdio mcp (initial messy version)
de6d1ae 
Signed-off-by: Jan Pokorný <[email protected]>
@JanPokorny
refactor: simplify code
b86e73d 
Signed-off-by: Jan Pokorný <[email protected]>
@JanPokorny
feat(agentstack-server): use single pod with sidecar pattern
37a5e13 
Signed-off-by: Jan Pokorný <[email protected]>
@JanPokorny
refactor: use kubectl wrapper
8b17c13 
Signed-off-by: Jan Pokorný <[email protected]>
@JanPokorny
refactor: simplify deployment
c5e0acb 
Signed-off-by: Jan Pokorný <[email protected]>
@JanPokorny
refactor: simplify code
a7fa408 
Signed-off-by: Jan Pokorný <[email protected]>
@JanPokorny
refactor: split services for managed and external MCP connectors
5cfd5b6 
Signed-off-by: Jan Pokorný <[email protected]>
@JanPokorny
fix: deploy managed MCP on connect/disconnect instead
43a90cd 
Signed-off-by: Jan Pokorný <[email protected]>
@JanPokorny
feat: finalize PR
21f1490 
Signed-off-by: Jan Pokorný <[email protected]>
@JanPokorny JanPokorny force-pushed the janpokorny/feat-agentstack-server-support-stdio-mcp branch from f0bdd44 to 21f1490 Compare December 1, 2025 13:53
@JanPokorny JanPokorny changed the title wip: support stdio mcp feat(agentstack-server): support stdio mcp Dec 1, 2025
@JanPokorny JanPokorny requested a review from pilartomas December 1, 2025 14:22
@JanPokorny JanPokorny marked this pull request as ready for review December 1, 2025 14:24
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Dec 1, 2025
@JanPokorny JanPokorny requested a review from pilartomas December 1, 2025 15:55
@JanPokorny JanPokorny force-pushed the janpokorny/feat-agentstack-server-support-stdio-mcp branch from 95799a9 to 16661a7 Compare December 1, 2025 15:59
pilartomas
pilartomas requested changes Dec 2, 2025
View reviewed changes
Copy link
Contributor

@pilartomas pilartomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small security issue, otherwise LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 2, 2025
@JanPokorny JanPokorny merged commit 128c63b into main Dec 2, 2025
10 checks passed
@JanPokorny JanPokorny deleted the janpokorny/feat-agentstack-server-support-stdio-mcp branch December 2, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pilartomas pilartomas pilartomas approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JanPokorny @pilartomas