-
Notifications
You must be signed in to change notification settings - Fork 137
feat(server): add json format to docling extraction #1652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): add json format to docling extraction #1652
Conversation
Summary of ChangesHello @aleskalfas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the text extraction capabilities by enabling support for JSON output from the docling service. It provides a flexible mechanism for users to specify extraction preferences through an Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for JSON output format from the Docling text extraction service. The changes correctly plumb the extras parameter from the API endpoint down to the service layer and Docling backend. My review has identified a critical runtime error in the Docling backend implementation due to an API mismatch, and a high-severity bug where extraction options are not updated when an extraction is retried. I've also included a medium-severity suggestion to improve code clarity in the streaming logic. Please address the critical and high severity issues.
apps/agentstack-server/src/agentstack_server/infrastructure/text_extraction/docling.py
Outdated
Show resolved
Hide resolved
apps/agentstack-server/src/agentstack_server/service_layer/services/files.py
Outdated
Show resolved
Hide resolved
apps/agentstack-server/src/agentstack_server/infrastructure/text_extraction/docling.py
Outdated
Show resolved
Hide resolved
6c48588 to
20b2135
Compare
apps/agentstack-server/src/agentstack_server/infrastructure/persistence/repositories/file.py
Outdated
Show resolved
Hide resolved
apps/agentstack-server/src/agentstack_server/infrastructure/text_extraction/docling.py
Outdated
Show resolved
Hide resolved
apps/agentstack-server/src/agentstack_server/service_layer/services/files.py
Show resolved
Hide resolved
apps/agentstack-server/src/agentstack_server/service_layer/services/files.py
Outdated
Show resolved
Hide resolved
apps/agentstack-server/src/agentstack_server/service_layer/services/files.py
Outdated
Show resolved
Hide resolved
e953b50 to
1b81494
Compare
Co-authored-by: Radek Ježek <[email protected]> Signed-off-by: Aleš Kalfas <[email protected]> Signed-off-by: Radek Ježek <[email protected]>
1b81494 to
61cfdd8
Compare
Refs #1630