Conversation
PetrBulanek
force-pushed
the
ui/a2a-error-extension
branch
from
df19307 to
aa8302a
Compare
dosubot
bot
added
the
size:L
PetrBulanek
changed the title
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces UI support for the A2A error extension, which is a great step towards providing more detailed and user-friendly error feedback. The changes are well-integrated, from defining the schema in the SDK to handling and displaying the errors in the UI. The introduction of the NotificationMarkdownContent component and the UX improvements to the Toast component are particularly noteworthy. My feedback includes a couple of minor suggestions to improve code clarity and formatting.
|
@PetrBulanek can we rebase this on top of latest main ? We have error extensions ready https://github.com/i-am-bee/agentstack/blob/main/apps/agentstack-sdk-py/src/agentstack_sdk/a2a/extensions/ui/error.py. |
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
PetrBulanek
force-pushed
the
ui/a2a-error-extension
branch
from
76e12a4 to
3708bae
Compare
We already tested it on Friday against the Python part, so it had already been rebased. I just rebased it again to see if there were any updates. :-) |
You are faster than me. Amazing, i briefly checked and the schema seems to be consistent with Py counterpart. Lets just test the integration. |
| const [overflowDetected, setOverflowDetected] = useState(false); | ||
|
|
||
| const showButton = isExpanded || overflowDetected; | ||
| const showButton = (isExpanded || overflowDetected) && (initialOverflowRef.current ?? true); |
There was a problem hiding this comment.
It's a bit hard to read what initialOverflowRef controls and how at first, I'd consider using descriptive states like: unset, overflowing, not-overflowing.
This condition could be then clearer - initialOverflowRef.current !== 'not-overflowing'. That doesn't seem right though, is it?:)
apps/agentstack-ui/src/components/NotificationMarkdownContent/NotificationMarkdownContent.tsx
Show resolved
Hide resolved
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
PetrBulanek
changed the title
3 participants
Summary
This PR adds UI support for displaying errors from the A2A error extension using our standard toast component. Each toast shows the required error message and title, and can optionally include context and a stacktrace, with code formatting for readability. The A2A error extension may return multiple errors (error group), and all errors in a group are displayed individually. This ensures clear, consistent visibility into A2A failures.
Linked Issues
Closes: #1618
Documentation
If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.