feat: Auto inject connected MCPs in UI #1695

tomkis · 2025-12-09T11:25:16Z

Summary

Adjusted the GUI code to automatically resolve MCP demands using connectors if available
Removed old approach of adding MCPs via textbox
Reworked MCP extension to optionally provide None for created MCP client instead of throwing error when no fullfilment is provided
Added Github MCP agent example
Consolidated docs for MCP Docs - consolidate MCP documentation #1542
Introduced cursor commands for ticket filing as well as documentation

Linked Issues

Documentation

No Docs Needed:

If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.

gemini-code-assist · 2025-12-09T11:25:30Z

Summary of Changes

Hello @tomkis, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new documentation file, CLAUDE.md, which outlines a structured process for filing GitHub issues within the i-am-bee/agentstack repository. The guidelines are detailed, covering template usage, user confirmation, and rules for concise and problem-focused issue descriptions. This change aims to standardize issue creation, though it seems to diverge from the feature described in the pull request's title.

Highlights

New Documentation File Added: A new markdown file, CLAUDE.md, has been introduced to the repository.
GitHub Issue Filing Guidelines: The added CLAUDE.md file provides comprehensive guidelines for filing GitHub issues, seemingly tailored for an automated agent or AI, detailing steps from reading templates to confirming the ticket with a user.
Issue Content Rules: Specific rules for issue content are outlined, emphasizing conciseness, problem definition over implementation details, and avoiding solutions in the issue description.
Discrepancy with PR Title: It's noted that the actual changes, which involve adding issue filing documentation, appear to be unrelated to the pull request title 'feat: Auto inject connected MCPs in UI'.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new file, CLAUDE.md, which seems to contain instructions for an AI on how to file GitHub issues. This change appears to be unrelated to the pull request's title, "feat: Auto inject connected MCPs in UI". Please clarify if this file was added intentionally to this PR. I have provided some feedback on the new file to improve its clarity and correct a typo.

CLAUDE.md

tomkis · 2025-12-09T13:59:23Z

Rebase on #1691 when merged.

tomkis · 2025-12-09T14:03:12Z

apps/agentstack-sdk-py/src/agentstack_sdk/a2a/extensions/services/mcp.py

    type: Literal["streamable_http"] = "streamable_http"

-    url: pydantic.AnyHttpUrl
+    url: str


The problem is that client can provide {platform_url}/foobar like in other url fields.

tomkis · 2025-12-10T12:02:43Z

This is a breaking change due to the fact that MCP client created through the MCP extension may return None if client doesn't provide this. Previously it was throwing an error.

kapetr · 2025-12-11T12:40:31Z

apps/agentstack-sdk-ts/src/client/api/types.ts

Do we want to keep all api types and schemas in one file?

kapetr · 2025-12-11T12:43:06Z

apps/agentstack-sdk-ts/src/client/api/build-api-client.ts

+  const listConnectors = async () => {
+    return await callApi('GET', '/api/v1/connectors', null, listConnectorsResponseSchema);
+  };


Just wondering, do we want to keep all API calls in this file? Nothing critical, but I'd consider splitting them by modules.

kapetr · 2025-12-11T12:50:11Z

apps/agentstack-ui/src/modules/connectors/api/index.ts

 export async function listConnectors(): Promise<ListConnectorsResponse | undefined> {
  const response = await api.GET('/api/v1/connectors', {});
-  return ensureData(response);
+  return ensureData(response) as ListConnectorsResponse;


Why not using agentstackClient.listConnectors()? Or delete the function altogether and use it directly.

Signed-off-by: Tomas Weiss <[email protected]>

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Tomáš Weiss <[email protected]>

Signed-off-by: Tomas Weiss <[email protected]>

gemini-code-assist bot reviewed Dec 9, 2025

View reviewed changes

CLAUDE.md Outdated Show resolved Hide resolved

CLAUDE.md Outdated Show resolved Hide resolved

CLAUDE.md Outdated Show resolved Hide resolved

tomkis commented Dec 9, 2025

View reviewed changes

tomkis force-pushed the feat/1694-auto-inject-connected-oauth-mcps branch 2 times, most recently from 8a532f4 to 472608b Compare December 10, 2025 09:53

tomkis added the breaking-change label Dec 10, 2025

tomkis marked this pull request as ready for review December 10, 2025 13:21

dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Dec 10, 2025

tomkis requested review from PetrBulanek, jezekra1 and kapetr December 11, 2025 11:42

jezekra1 approved these changes Dec 11, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 11, 2025

kapetr reviewed Dec 11, 2025

View reviewed changes

tomkis force-pushed the feat/1694-auto-inject-connected-oauth-mcps branch from 6107b33 to ac1072b Compare December 12, 2025 07:45

tomkis and others added 13 commits December 12, 2025 11:22

feat: CLAUDE.md for ticket filing

92bd40e

Signed-off-by: Tomas Weiss <[email protected]>

feat: add example agent for github mcp

0c6d04d

Signed-off-by: Tomas Weiss <[email protected]>

feat: expose connectors list in the SDK

847da72

Signed-off-by: Tomas Weiss <[email protected]>

feat: matching connectors with MCP demands

b1e9df4

Signed-off-by: Tomas Weiss <[email protected]>

Update CLAUDE.md

5dd2c18

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Tomáš Weiss <[email protected]>

chore: fixing build

9750232

Signed-off-by: Tomas Weiss <[email protected]>

fix: claude prompting

273eb79

Signed-off-by: Tomas Weiss <[email protected]>

feat: use cursor rules instead of claude.md

6a74436

Signed-off-by: Tomas Weiss <[email protected]>

chore: make MCP client optional

a77f9b5

Signed-off-by: Tomas Weiss <[email protected]>

chore: remove selection of MCP in GUI

e30bc36

Signed-off-by: Tomas Weiss <[email protected]>

docs: mcp

4255f2a

Signed-off-by: Tomas Weiss <[email protected]>

docs: remove trailing reference

c2af686

Signed-off-by: Tomas Weiss <[email protected]>

docs: bump

45da49c

Signed-off-by: Tomas Weiss <[email protected]>

tomkis added 4 commits December 12, 2025 11:22

docs: connectors - better clarity

9c9ec69

Signed-off-by: Tomas Weiss <[email protected]>

fix: docs post rebase

0ac3af1

Signed-off-by: Tomas Weiss <[email protected]>

fix: post rebase

08574e7

Signed-off-by: Tomas Weiss <[email protected]>

fix: revert docs changes in stable

4b1a3f5

Signed-off-by: Tomas Weiss <[email protected]>

tomkis force-pushed the feat/1694-auto-inject-connected-oauth-mcps branch from 9883c70 to 4b1a3f5 Compare December 12, 2025 10:22

fix: typing

2833911

Signed-off-by: Tomas Weiss <[email protected]>

tomkis merged commit 221bf44 into main Dec 12, 2025
12 checks passed

tomkis deleted the feat/1694-auto-inject-connected-oauth-mcps branch December 12, 2025 11:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Auto inject connected MCPs in UI #1695

feat: Auto inject connected MCPs in UI #1695

Uh oh!

tomkis commented Dec 9, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Dec 9, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tomkis commented Dec 9, 2025 •

edited

Loading

Uh oh!

tomkis Dec 9, 2025

Uh oh!

tomkis commented Dec 10, 2025

Uh oh!

kapetr Dec 11, 2025

Uh oh!

kapetr Dec 11, 2025

Uh oh!

kapetr Dec 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: Auto inject connected MCPs in UI #1695

feat: Auto inject connected MCPs in UI #1695

Uh oh!

Conversation

tomkis commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Linked Issues

Documentation

Uh oh!

gemini-code-assist bot commented Dec 9, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tomkis commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tomkis Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

tomkis commented Dec 10, 2025

Uh oh!

kapetr Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

kapetr Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

kapetr Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tomkis commented Dec 9, 2025 •

edited

Loading

tomkis commented Dec 9, 2025 •

edited

Loading