fix(sdk): remove dependency on email-validator

[jezekra1]

Summary

Linked Issues

Documentation

• No Docs Needed:

If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.

[gemini-code-assist]

Summary of Changes

Hello @jezekra1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the agentstack-sdk-py by streamlining its dependencies and enhancing its testing infrastructure. The primary goal is to reduce external package requirements and improve the robustness of the SDK by ensuring all modules can be imported without issues, contributing to a more stable and maintainable codebase.

Highlights

• Dependency Removal: The email field in the User Pydantic model has been changed from pydantic.EmailStr to str, effectively removing the implicit dependency on the email-validator package.
• Test Task Renaming: The test task agentstack-sdk-py:e2e-test in tasks.toml has been renamed to agentstack-sdk-py:test for clarity.
• New Unit Test Added: A new unit test file test_import_all.py has been introduced, which includes a test to recursively import all packages within agentstack_sdk to ensure there are no syntax errors or missing dependencies.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/sdk-py-test.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the email-validator dependency by changing pydantic.EmailStr to a plain str in the User model. This is a good move to reduce dependencies. To support this change, a new unit test has been added to ensure all modules can be imported without issues, which is excellent practice.

My review includes two main points:

1. In user.py, I've suggested re-introducing a basic form of email validation using a regex. This maintains data integrity without relying on the external email-validator package.
2. In the new test file test_import_all.py, I've suggested a small improvement to the exception handling to provide better stack traces on failure, which will aid in debugging.

Overall, the changes are positive, and my suggestions aim to enhance the robustness and maintainability of the code.