-
Notifications
You must be signed in to change notification settings - Fork 137
docs: split development / stable #1709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @JanPokorny, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a robust documentation versioning system, distinguishing between 'development' and 'stable' content. It involves a comprehensive restructuring of the documentation file paths, updating the navigation configuration to reflect these versions, and establishing an automated process to manage the synchronization of documentation content between these two states during release cycles. This enhancement aims to provide clearer, version-specific documentation for users and developers. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a versioning system for the documentation, splitting it into stable and development branches. This is a significant structural change involving renaming many files and updating the navigation configuration in docs/docs.json. The changes are consistent with the goal of versioning the documentation. My main feedback concerns the maintainability of the new docs.json due to duplicated configuration, which I've detailed in a specific comment. The related update to the release script in tasks.toml appears to be functionally correct for this new structure.
Signed-off-by: Jan Pokorný <[email protected]>
2db59c8 to
ef1523f
Compare
Signed-off-by: Jan Pokorný <[email protected]>
6874858 to
08a2571
Compare
Summary
Linked Issues
Fixes #1707
Documentation
If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.