Skip to content

Conversation

@PetrBulanek
Copy link
Contributor

Summary

This PR adds support for managing connector presets directly in the UI. Available presets are now displayed, allowing users to connect or disconnect them without manually creating connectors.

Linked Issues

Closes: #1697

Documentation

  • No Docs Needed:

@PetrBulanek PetrBulanek requested review from kapetr and tomkis December 12, 2025 10:31
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 12, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @PetrBulanek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the user experience for managing connectors by introducing a new feature for connector presets. Instead of requiring users to manually input details for every connector, the UI now presents a curated list of available presets. Users can effortlessly connect or disconnect these predefined connectors, with the system intelligently handling the creation of new connectors when a preset is selected for the first time. This change streamlines the connector setup process, making it more intuitive and efficient.

Highlights

  • Connector Presets UI: Introduced a new UI flow within the 'Add connector' modal, allowing users to browse and manage predefined connector presets, significantly streamlining the connector setup process.
  • API Integration for Presets: Added new API functions (listConnectorPresets) and React Query hooks (useListConnectorPresets) to efficiently fetch and manage connector presets from the backend.
  • Dynamic Connect/Disconnect Functionality: Implemented the ability to connect or disconnect a preset directly from the list, automatically handling the creation of a new connector if the preset is not yet added.
  • Refactored Add Connector Modal: The AddConnectorModal was refactored to support switching between adding a custom connector and browsing presets, enhancing user experience and modularity.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a valuable feature for managing connector presets through the UI, allowing users to easily browse, connect, and disconnect them. The implementation is well-structured, with new components effectively separating concerns and a thoughtful refactoring of the AddConnectorModal to accommodate both preset browsing and custom connector creation. The code quality is high, but I've identified a few minor issues related to form validation logic, a user-facing loading message, and code organization that could be improved.

Signed-off-by: Petr Bulánek <[email protected]>
Signed-off-by: Petr Bulánek <[email protected]>
@PetrBulanek
Copy link
Contributor Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a valuable feature by adding UI support for connector presets. The implementation is well-structured, creating new components for presets and refactoring the AddConnectorModal to handle both presets and custom connectors. I've identified a potential race condition in the ConnectPresetButton that could result in unintended duplicate actions, and I've provided suggestions to resolve it. Additionally, I have a minor recommendation for code organization to enhance maintainability. Overall, this is a solid contribution.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 15, 2025
@PetrBulanek PetrBulanek merged commit 76393f6 into main Dec 15, 2025
8 checks passed
@PetrBulanek PetrBulanek deleted the ui/connector-presets branch December 15, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manage Connector presets in the UI

3 participants