[DRAFT] feat(ui): move API to SDK #1737

PetrBulanek · 2025-12-18T11:19:50Z

Summary

Linked Issues

Closes: #1692

Documentation

No Docs Needed:

If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.

Signed-off-by: Petr Bulánek <[email protected]>

apps/agentstack-sdk-ts/src/client/client/utils.ts

gemini-code-assist · 2025-12-18T11:21:13Z

Summary of Changes

Hello @PetrBulanek, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a major architectural overhaul by migrating the existing API client and A2A extensions into a newly structured SDK. The primary goal is to enhance modularity, type safety, and error handling across the platform. The changes involve a comprehensive reorganization of code, the introduction of a more robust API interaction pattern, and a full update of the UI application to seamlessly adopt these new SDK capabilities.

Highlights

SDK Restructuring: The agentstack-sdk-ts package has undergone a significant restructuring, moving from a monolithic API client to a modular design. This involves creating dedicated subdirectories for various A2A extensions (e.g., auth, services, ui) and API domains (e.g., configuration, connectors, contexts, model-providers, users), each with its own index.ts, schemas.ts, and types.ts files.
New API Client and Error Handling: A new core API client (buildApiClient) has been introduced in the SDK, along with a standardized unwrapResult utility for handling API responses. This new approach also includes a robust error handling mechanism with ApiErrorException and specific error types (Http, Network, Parse, Validation) to improve reliability and developer experience.
UI Application Alignment: The agentstack-ui application has been comprehensively updated to integrate with the new SDK structure. This includes adjusting imports, updating function calls (e.g., agentstackClient to agentStackClient, matchProviders to matchModelProviders), and aligning type definitions to consume the refactored SDK components.
Enhanced Type Safety and Schema Definition: The refactoring heavily leverages Zod schemas and TypeScript types across all new and refactored modules. This ensures stronger type safety, clearer API contracts, and better maintainability for both the SDK and the UI.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a significant and well-executed refactoring, moving the API client logic and type definitions into a dedicated agentstack-sdk-ts package. This greatly improves the overall architecture by creating a clear separation of concerns, enhancing type safety, and establishing a more robust and reusable API client. The new structure with a core API builder, modular endpoints, and structured error handling is a major step forward.

My review has identified a recurring critical issue across several new Zod schema definitions where z.enum() is used incorrectly with TypeScript enums, which will cause runtime errors. I've left specific comments with suggestions to use z.nativeEnum() instead. I also found a minor opportunity to improve the robustness of a URL-building utility function.

Once these issues are addressed, this will be an excellent contribution to the codebase.

apps/agentstack-sdk-ts/src/client/a2a/extensions/services/mcp/schemas.ts

apps/agentstack-sdk-ts/src/client/a2a/extensions/ui/agent-detail/schemas.ts

apps/agentstack-sdk-ts/src/client/api/connectors/schemas.ts

apps/agentstack-sdk-ts/src/client/api/model-providers/schemas.ts

apps/agentstack-sdk-ts/src/client/api/users/schemas.ts

gemini-code-assist · 2025-12-18T11:32:37Z

apps/agentstack-sdk-ts/src/client/api/core/utils.ts

+    Object.entries(data).forEach(([key, value]) => {
+      if (value != null) {
+        searchParams.append(key, String(value));
+      }
+    });


The current implementation for building query parameters from a data object converts array values to a single comma-separated string. This might not be what the server expects for multi-valued parameters. A more standard and robust approach is to append each item of the array separately to the URLSearchParams. This will generate query parameters like key=value1&key=value2 instead of key=value1,value2.

Suggested change

Object.entries(data).forEach(([key, value]) => {

if (value != null) {

searchParams.append(key, String(value));

}

});

Object.entries(data).forEach(([key, value]) => {

if (value != null) {

if (Array.isArray(value)) {

value.forEach((item) => searchParams.append(key, String(item)));

} else {

searchParams.append(key, String(value));

}

}

});

Signed-off-by: Petr Bulánek <[email protected]>

apps/agentstack-sdk-ts/src/client/client/utils.ts

Signed-off-by: Petr Bulánek <[email protected]>

apps/agentstack-sdk-ts/src/client/client/utils.ts

+import type { ApiMethod } from './types';
+
+export function buildRequestUrl({ baseUrl, path, query }: { baseUrl: string; path: string; query?: ApiQueryParams }) {
+  const url = `${baseUrl.replace(/\/+$/, '')}${path}`;


Signed-off-by: Petr Bulánek <[email protected]>

tomkis · 2025-12-29T07:26:02Z

apps/agentstack-sdk-ts/src/index.ts

-export * from './client/a2a/extensions/services/oauth-provider';
-export * from './client/a2a/extensions/services/platform';
-export * from './client/a2a/extensions/services/secrets';
+export * from './client/a2a/extensions';


Have you been considering creating directory structure that always contains index.ts and then the imports are a hierarchy of imported folders? Basically each module contains index.ts exporting everything from the module.

It seems a bit awkward to enumerate internal details of each module here.

Obviously my suggestion is recursive (let's not over-abuse the depth - eg one max two levels of modules would do).

I am proposing having seperate modules for:

Client

extensions

api

core

tomkis · 2025-12-29T07:26:42Z

apps/agentstack-sdk-ts/src/extensions.ts

+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+export * from './client/a2a/extensions';


basically this can be renamed to index.ts and moved to ./client/a2a/extensions to encapsulate all the stuff.

tomkis · 2025-12-29T07:43:08Z

apps/agentstack-sdk-ts/src/client/a2a/protocol/schemas.ts

+
+export const fileWithBytesSchema = z.object({
+  bytes: z.string(),
+  mimeType: z.string().nullish(),


I believe all the nullish here is wrong.

The protocol defines the values as undefined not nullish.

This won't work in environments where plain a2a is used.

See https://a2a-protocol.org/latest/specification/#57-field-presence-and-optionality for further reference. cc @jezekra1

tomkis · 2025-12-29T07:44:42Z

apps/agentstack-sdk-ts/src/client/a2a/runtime/buildLLMExtensionFulfillmentResolver.ts

-import type { ContextToken } from '../../../api/types';
-import { ModelCapability } from '../../../api/types';
-import type { LLMDemands, LLMFulfillments } from '../services/llm';
+import type { ContextToken } from '../../api/types';


I'd move this in fulfillment-resolvers folder, there will potentialy be more of those and it's sort of separate module.

tomkis · 2025-12-29T07:45:10Z

apps/agentstack-sdk-ts/src/client/a2a/runtime/buildMessageBuilder.ts


-import type { Fulfillments } from '../handle-agent-card';
-import { handleAgentCard } from '../handle-agent-card';
+import { handleAgentCard } from './handleAgentCard';


This is an util - i'd create here separate util folder and move it there.

tomkis · 2025-12-29T07:45:57Z

apps/agentstack-sdk-ts/src/client/a2a/runtime/extract.ts

 import type { A2AServiceExtension, A2AUiExtension } from './types';

 export function extractUiExtensionData<U extends string, D>(extension: A2AUiExtension<U, D>) {
  const schema = extension.getMessageMetadataSchema();


I'd create extensions folder for everything related to extensions (that is not a2a schema definition).

so eg. this extract, fulfill

tomkis · 2025-12-29T07:46:17Z

apps/agentstack-sdk-ts/src/client/a2a/runtime/resolveUserMetadata.ts

+import { formRequestExtension } from '../extensions/ui/form-request';
+import type { UserMetadataInputs } from './types';
+
+export const resolveUserMetadata = async (inputs: UserMetadataInputs) => {


Another extension specific file.

tomkis · 2025-12-29T07:47:44Z

apps/agentstack-sdk-ts/src/client/client/index.ts

@@ -0,0 +1,147 @@
+/**
+ * Copyright 2025 © BeeAI a Series of LF Projects, LLC


Shouldnt this whole module be owned by the api folder? It's api after all?

tomkis · 2025-12-29T07:48:04Z

apps/agentstack-sdk-ts/src/client/errors/index.ts

@@ -0,0 +1,41 @@
+/**


Another one that could be owned by api module.

Signed-off-by: Petr Bulánek <[email protected]>

PetrBulanek added 7 commits December 17, 2025 14:27

feat(ui): move API to SDK (/users)

a344fa4

Signed-off-by: Petr Bulánek <[email protected]>

feat(ui): add base for error handling

80556a6

Signed-off-by: Petr Bulánek <[email protected]>

chore(ui): SDK folder structure rework (wip)

0433498

Signed-off-by: Petr Bulánek <[email protected]>

fixup! chore(ui): SDK folder structure rework (wip)

5800f00

Signed-off-by: Petr Bulánek <[email protected]>

fixup! fixup! chore(ui): SDK folder structure rework (wip)

f2c492e

Signed-off-by: Petr Bulánek <[email protected]>

feat(ui): add connectors api

92bfa96

Signed-off-by: Petr Bulánek <[email protected]>

feat(ui): add configuration api

a193e5e

Signed-off-by: Petr Bulánek <[email protected]>

PetrBulanek requested review from kapetr and tomkis December 18, 2025 11:19

github-advanced-security bot found potential problems Dec 18, 2025

View reviewed changes

apps/agentstack-sdk-ts/src/client/client/utils.ts Fixed Show fixed Hide fixed

PetrBulanek changed the title ~~feat(ui): move API to SDK~~ [DRAFT] feat(ui): move API to SDK Dec 18, 2025

gemini-code-assist bot reviewed Dec 18, 2025

View reviewed changes

PetrBulanek added 2 commits December 18, 2025 18:10

feat(ui): add contexts api

0df181e

Signed-off-by: Petr Bulánek <[email protected]>

feat(ui): add files api (wip)

eacfe1e

Signed-off-by: Petr Bulánek <[email protected]>

github-advanced-security bot found potential problems Dec 19, 2025

View reviewed changes

apps/agentstack-sdk-ts/src/client/client/utils.ts Fixed Show fixed Hide fixed

chore(ui): update sdk folder structure

944f4d2

Signed-off-by: Petr Bulánek <[email protected]>

github-advanced-security bot found potential problems Dec 19, 2025

View reviewed changes

PetrBulanek added 5 commits December 19, 2025 13:30

feat(ui): add package entrypoints

bc0cfc5

Signed-off-by: Petr Bulánek <[email protected]>

feat(ui): add response schemas

c295201

Signed-off-by: Petr Bulánek <[email protected]>

feat(ui): add files api

ea5f1b7

Signed-off-by: Petr Bulánek <[email protected]>

feat(ui): add model providers api

92427fb

Signed-off-by: Petr Bulánek <[email protected]>

feat(ui): add provider builds api (wip)

7d40716

Signed-off-by: Petr Bulánek <[email protected]>

tomkis reviewed Dec 29, 2025

View reviewed changes

PetrBulanek added 5 commits January 5, 2026 16:13

feat(ui): add provider builds api

264dab7

Signed-off-by: Petr Bulánek <[email protected]>

feat(ui): add providers api

0aa2585

Signed-off-by: Petr Bulánek <[email protected]>

feat(ui): add user feedback api

de39739

Signed-off-by: Petr Bulánek <[email protected]>

feat(ui): add missing api endpoints + error handling (work in progress)

6020b10

Signed-off-by: Petr Bulánek <[email protected]>

feat(ui): fix api error handling

3d0f751

Signed-off-by: Petr Bulánek <[email protected]>

		@@ -0,0 +1,147 @@
		/**
		* Copyright 2025 © BeeAI a Series of LF Projects, LLC

[DRAFT] feat(ui): move API to SDK #1737

Are you sure you want to change the base?

[DRAFT] feat(ui): move API to SDK #1737

Conversation

PetrBulanek commented Dec 18, 2025

Summary

Linked Issues

Documentation

Uh oh!

Uh oh!

gemini-code-assist bot commented Dec 18, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Check failure

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants