feat(ui): move API to SDK #1737

PetrBulanek · 2025-12-18T11:19:50Z

Summary

Replace deprecated openapi-fetch client in UI with agentstack-sdk client usage across configuration, connectors, contexts, files, model providers, providers, user feedback, users and variables modules; remove legacy UI API types/utils.
Extend the SDK with a new API core (typed ApiResult, zod validation, streaming responses, file upload FormData handling, and structured error types).
Add A2A protocol schemas/types to the SDK and reorganize extension schemas/types; update UI A2A imports and error handling to use SDK helpers.
Improve error handling across SDK/UI, including typed API error inspection.

Linked Issues

Refs: #1692

Documentation

No Docs Needed:

This PR is already huge in itself, so the documentation will be part of additional PR.

apps/agentstack-sdk-ts/src/client/api/core/utils.ts

gemini-code-assist · 2025-12-18T11:21:13Z

Summary of Changes

Hello @PetrBulanek, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a major architectural overhaul by migrating the existing API client and A2A extensions into a newly structured SDK. The primary goal is to enhance modularity, type safety, and error handling across the platform. The changes involve a comprehensive reorganization of code, the introduction of a more robust API interaction pattern, and a full update of the UI application to seamlessly adopt these new SDK capabilities.

Highlights

SDK Restructuring: The agentstack-sdk-ts package has undergone a significant restructuring, moving from a monolithic API client to a modular design. This involves creating dedicated subdirectories for various A2A extensions (e.g., auth, services, ui) and API domains (e.g., configuration, connectors, contexts, model-providers, users), each with its own index.ts, schemas.ts, and types.ts files.
New API Client and Error Handling: A new core API client (buildApiClient) has been introduced in the SDK, along with a standardized unwrapResult utility for handling API responses. This new approach also includes a robust error handling mechanism with ApiErrorException and specific error types (Http, Network, Parse, Validation) to improve reliability and developer experience.
UI Application Alignment: The agentstack-ui application has been comprehensively updated to integrate with the new SDK structure. This includes adjusting imports, updating function calls (e.g., agentstackClient to agentStackClient, matchProviders to matchModelProviders), and aligning type definitions to consume the refactored SDK components.
Enhanced Type Safety and Schema Definition: The refactoring heavily leverages Zod schemas and TypeScript types across all new and refactored modules. This ensures stronger type safety, clearer API contracts, and better maintainability for both the SDK and the UI.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a significant and well-executed refactoring, moving the API client logic and type definitions into a dedicated agentstack-sdk-ts package. This greatly improves the overall architecture by creating a clear separation of concerns, enhancing type safety, and establishing a more robust and reusable API client. The new structure with a core API builder, modular endpoints, and structured error handling is a major step forward.

My review has identified a recurring critical issue across several new Zod schema definitions where z.enum() is used incorrectly with TypeScript enums, which will cause runtime errors. I've left specific comments with suggestions to use z.nativeEnum() instead. I also found a minor opportunity to improve the robustness of a URL-building utility function.

Once these issues are addressed, this will be an excellent contribution to the codebase.

apps/agentstack-sdk-ts/src/client/a2a/extensions/services/mcp/schemas.ts

apps/agentstack-sdk-ts/src/client/a2a/extensions/ui/agent-detail/schemas.ts

apps/agentstack-sdk-ts/src/client/api/connectors/schemas.ts

apps/agentstack-sdk-ts/src/client/api/model-providers/schemas.ts

apps/agentstack-sdk-ts/src/client/api/users/schemas.ts

apps/agentstack-sdk-ts/src/client/api/core/utils.ts

apps/agentstack-sdk-ts/src/index.ts

apps/agentstack-sdk-ts/src/extensions.ts

apps/agentstack-sdk-ts/src/client/a2a/protocol/schemas.ts

apps/agentstack-sdk-ts/src/client/a2a/runtime/buildLLMExtensionFulfillmentResolver.ts

apps/agentstack-sdk-ts/src/client/a2a/runtime/buildMessageBuilder.ts

apps/agentstack-sdk-ts/src/client/core/extensions/extract.ts

apps/agentstack-sdk-ts/src/client/core/extensions/resolve-user-metadata.ts

apps/agentstack-sdk-ts/src/client/api/core/client.ts

apps/agentstack-sdk-ts/src/client/api/core/errors/utils.ts

PetrBulanek · 2026-01-12T09:31:39Z

/gemini review

gemini-code-assist

Code Review

This is an excellent and extensive refactoring that significantly improves the codebase. Moving to the new agentstack-sdk with its well-defined API client, structured types, and improved error handling is a major step forward for maintainability and developer experience. The modularization of the SDK into core, api, and extensions is very clean. The consistent use of Zod for schema validation and type inference is also a great practice. The changes in the UI to adapt to the new SDK are well-executed. I've found a few minor issues and one critical one related to schema definitions, but overall, this is a very high-quality pull request.

apps/agentstack-sdk-ts/src/client/a2a/extensions/services/mcp/schemas.ts

apps/agentstack-ui/src/app/(main)/agent/[providerId]/rsc.tsx

apps/agentstack-sdk-ts/src/client/api/contexts/schemas.ts

apps/agentstack-sdk-ts/src/client/core/handleAgentCard.ts

tomkis · 2026-01-12T10:07:47Z

This is a breaking change for the whole TS SDK.

kapetr

just a partail review - I'll continue tomorrow :)

apps/agentstack-ui/src/api/a2a/client.ts

apps/agentstack-ui/src/api/agentstack-client.ts

apps/agentstack-ui/src/api/schema.d.ts

apps/agentstack-ui/src/app/(main)/agent/[providerId]/ensure-model-selected.tsx

kapetr

The SDK fails to validate /providers response as the API doesn't align with a2a types on null values, while the SDK schema does.

apps/agentstack-sdk-ts/src/client/api/core/client.ts

kapetr · 2026-01-14T12:28:09Z

apps/agentstack-sdk-ts/src/client/a2a/protocol/utils.ts

+    if (data === null || typeof data !== 'object' || Array.isArray(data)) {
+      return data;
+    }


Wouldn't this bypass normalization for objects inside arrays?

Signed-off-by: Petr Bulánek <[email protected]> feat(ui): add base for error handling Signed-off-by: Petr Bulánek <[email protected]> chore(ui): SDK folder structure rework (wip) Signed-off-by: Petr Bulánek <[email protected]> Signed-off-by: Petr Bulánek <[email protected]> Signed-off-by: Petr Bulánek <[email protected]> feat(ui): add connectors api Signed-off-by: Petr Bulánek <[email protected]> feat(ui): add configuration api Signed-off-by: Petr Bulánek <[email protected]> feat(ui): add contexts api Signed-off-by: Petr Bulánek <[email protected]> feat(ui): add files api (wip) Signed-off-by: Petr Bulánek <[email protected]> chore(ui): update sdk folder structure Signed-off-by: Petr Bulánek <[email protected]> feat(ui): add package entrypoints Signed-off-by: Petr Bulánek <[email protected]> feat(ui): add response schemas Signed-off-by: Petr Bulánek <[email protected]> feat(ui): add files api Signed-off-by: Petr Bulánek <[email protected]> feat(ui): add model providers api Signed-off-by: Petr Bulánek <[email protected]> feat(ui): add provider builds api (wip) Signed-off-by: Petr Bulánek <[email protected]> feat(ui): add provider builds api Signed-off-by: Petr Bulánek <[email protected]> feat(ui): add providers api Signed-off-by: Petr Bulánek <[email protected]> feat(ui): add user feedback api Signed-off-by: Petr Bulánek <[email protected]> feat(ui): add missing api endpoints + error handling (work in progress) Signed-off-by: Petr Bulánek <[email protected]> feat(ui): fix api error handling Signed-off-by: Petr Bulánek <[email protected]> feat(ui): folder structure fix(ui): circular exports Signed-off-by: Petr Bulánek <[email protected]>

Signed-off-by: Petr Bulánek <[email protected]>

PetrBulanek requested review from kapetr and tomkis December 18, 2025 11:19

github-advanced-security bot found potential problems Dec 18, 2025

View reviewed changes

apps/agentstack-sdk-ts/src/client/api/core/utils.ts Fixed Show fixed Hide fixed

PetrBulanek changed the title ~~feat(ui): move API to SDK~~ [DRAFT] feat(ui): move API to SDK Dec 18, 2025

gemini-code-assist bot reviewed Dec 18, 2025

View reviewed changes

github-advanced-security bot found potential problems Dec 19, 2025

View reviewed changes

apps/agentstack-sdk-ts/src/client/api/core/utils.ts Dismissed Show dismissed Hide dismissed

github-advanced-security bot found potential problems Dec 19, 2025

View reviewed changes

apps/agentstack-sdk-ts/src/client/api/core/utils.ts Fixed Show fixed Hide fixed

tomkis reviewed Dec 29, 2025

View reviewed changes

PetrBulanek force-pushed the ui/move-api-to-sdk branch from 82f8c7a to 1d5300c Compare January 9, 2026 15:31

PetrBulanek changed the title ~~[DRAFT] feat(ui): move API to SDK~~ feat(ui): move API to SDK Jan 12, 2026

PetrBulanek marked this pull request as ready for review January 12, 2026 09:31

dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jan 12, 2026

gemini-code-assist bot reviewed Jan 12, 2026

View reviewed changes

tomkis added the breaking-change label Jan 12, 2026

kapetr reviewed Jan 12, 2026

View reviewed changes

kapetr requested changes Jan 13, 2026

View reviewed changes

apps/agentstack-sdk-ts/src/client/api/core/client.ts Show resolved Hide resolved

PetrBulanek requested review from kapetr and tomkis January 13, 2026 13:26

kapetr reviewed Jan 14, 2026

View reviewed changes

PetrBulanek added 4 commits January 14, 2026 15:58

feat(ui): add approval extension + missing a2a types

bc9f01c

Signed-off-by: Petr Bulánek <[email protected]>

feat(ui): normalize a2a null values to undefined

38b847b

Signed-off-by: Petr Bulánek <[email protected]>

fixup! feat(ui): normalize a2a null values to undefined

bf13105

Signed-off-by: Petr Bulánek <[email protected]>

PetrBulanek force-pushed the ui/move-api-to-sdk branch from 72fa74d to bf13105 Compare January 14, 2026 15:01

PetrBulanek requested a review from kapetr January 14, 2026 15:02

kapetr approved these changes Jan 14, 2026

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 14, 2026

PetrBulanek merged commit d44d0f3 into main Jan 15, 2026
8 checks passed

PetrBulanek deleted the ui/move-api-to-sdk branch January 15, 2026 10:27

feat(ui): move API to SDK #1737

feat(ui): move API to SDK #1737

Uh oh!

Conversation

PetrBulanek commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Linked Issues

Documentation

Uh oh!

Uh oh!

gemini-code-assist bot commented Dec 18, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PetrBulanek commented Jan 12, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tomkis commented Jan 12, 2026

Uh oh!

kapetr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kapetr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kapetr Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PetrBulanek commented Dec 18, 2025 •

edited

Loading