-
Notifications
You must be signed in to change notification settings - Fork 137
Platfrom Auth API UI rework #1752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @tomkis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the platform's authentication and authorization API interactions, primarily focusing on Agent-to-Agent (A2A) communication. It introduces a new utility for creating authenticated fetch requests, centralizing token handling. Concurrently, it enhances the validation of global permissions, particularly for A2A proxy access, by implementing stricter schema-based rules. These changes streamline how authentication tokens are managed and applied, ensuring more consistent and secure API calls across the SDK and UI. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the authentication and API client creation logic in the AgentStack UI and SDK. A new createAuthenticatedFetch helper is introduced in the TypeScript SDK to standardize adding authentication headers, and this is used to clean up the UI code. Validation for permission grants has been improved by moving it into Zod schemas, which is a great change.
Overall, the changes are well-structured and improve the codebase. I have one minor suggestion to remove a leftover console.log statement.
Also, there's a small typo in the pull request title: "Platfrom" should be "Platform".
5f61976 to
73f696f
Compare
Signed-off-by: Tomas Weiss <[email protected]>
Signed-off-by: Tomas Weiss <[email protected]>
adf3912 to
383a225
Compare
Summary
Refactoring of platform auth in the UI fixes code review comments in #1741
Documentation
Base does not yet have any docs.