Skip to content

Conversation

@JanPokorny
Copy link
Collaborator

Summary

Linked Issues

Fixes #1285

Documentation

  • No Docs Needed:

If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 6, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @JanPokorny, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue in the agentstack-cli's --dump-files functionality by enhancing its ability to handle various Uniform Resource Identifiers (URIs). It introduces specific logic to recognize and correctly load files referenced by agentstack:// URIs, which are internal to the platform. Additionally, it refines the handling of external HTTP/HTTPS URIs by removing an erroneous base64 decoding step, ensuring accurate file content retrieval and saving.

Highlights

  • Platform File URI Support: The agentstack-cli now correctly processes platform-specific agentstack:// URIs when using the --dump-files command, enabling proper retrieval of internal platform files.
  • Refined URI Handling Logic: The _run_agent function has been updated to differentiate between agentstack:// URIs and external HTTP/HTTPS URIs, applying appropriate fetching mechanisms for each.
  • Removed Unnecessary Base64 Decoding: An incorrect base64.b64decode call has been removed for content fetched from external HTTP/HTTPS URIs, ensuring that file content is written directly as bytes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the --dump-files functionality by adding support for platform-native files using agentstack:// URIs. It also corrects a bug in handling generic HTTP URIs where file content was being incorrectly base64-decoded. My review identifies a minor performance improvement opportunity by reusing the httpx.AsyncClient across multiple file downloads within a single agent run.

@JanPokorny JanPokorny merged commit 20546e3 into main Jan 6, 2026
10 checks passed
@JanPokorny JanPokorny deleted the janpokorny/fix-agentstack-cli-support-platform-files-in-dump-files branch January 6, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agents cannot detect execution environment (CLI vs UI)

2 participants