docs: refine SKILL.md and references for package-first discovery#2299
docs: refine SKILL.md and references for package-first discovery#2299
Conversation
- Prioritize package introspection over documentation for imports. - Add -qq flag to pip installation commands for cleaner output. - Include rules for polling secrets and trajectory yielding. - Update Source-of-Truth precedence in SKILL.md. Signed-off-by: Lukáš Janeček <xjacka@gmail.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the guidelines for wrapping Python agents by establishing a 'package-first' approach for resolving import paths and types, prioritizing runtime introspection over documentation. It clarifies the roles of various information sources, ensuring that documentation focuses on architectural patterns and behavior while code introspection handles exact implementation details. The changes also introduce specific instructions for handling secrets and trajectory extensions, and improve the clarity of dependency installation commands. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refines the SKILL.md and related reference documentation to emphasize a "package-first" approach for discovering import paths, class names, and types, shifting priority from documentation to direct package introspection. It updates the source-of-truth precedence rules, adds new anti-patterns for handling secrets and trajectory output, and incorporates the -qq flag for pip installation commands to ensure cleaner output. These changes align with the goal of streamlining the agent wrapping process by leveraging runtime introspection for accurate implementation details.
Note: Security Review has been skipped due to the limited scope of the PR.
Signed-off-by: Lukáš Janeček <xjacka@gmail.com>
| **Primary Method (Inline Package Search):** | ||
| To figure out exact imports from installed libraries (`agentstack_sdk`, `a2a`), you **must** use inline Python execution (`python -c`) to map imports without polluting the project repository. Do not guess import paths or rely solely on documentation if the package is installed. |
There was a problem hiding this comment.
This is quite a turn around to previous approach (that worked well for me, for Codex and Claude Opus at least), but let's put it to the test!
…discovery Signed-off-by: Lukáš Janeček <xjacka@gmail.com>
Summary
Linked Issues
Documentation
If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.