docs: Update example of using GlobalTrajectoryMiddleware to specify what to logs#1412
docs: Update example of using GlobalTrajectoryMiddleware to specify what to logs#1412yuit wants to merge 1 commit intoi-am-bee:mainfrom
Conversation
… include Signed-off-by: Yui <yuit@users.noreply.github.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an out-of-date example in the documentation for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request corrects an example in the documentation for GlobalTrajectoryMiddleware. The target parameter was being used to specify which classes to log, which was incorrect. This has been updated to use the included parameter, which is the correct way to filter logged classes. This change makes the documentation consistent with the implementation, which will help prevent user confusion.
Which issue(s) does this pull-request address?
Example is out-of-date. Examples incorrectly use
targetparameter to specify what to include in trajectory.Description
Update the example to use
includedinstead oftargetChecklist
General
/ TypeScript
Pythonfor Python changes,TypeScriptfor TypeScript changesCode quality checks
mise check(mise fixto auto-fix)Testing
mise test:unitmise test:e2eDocumentation
mise docs:fix