[Aikido] Fix security issue in urllib3 via minor version upgrade from 2.5.0 to 2.6.3 in plausible-to-posthog#176
Open
aikido-autofix[bot] wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade urllib3 to mitigate critical decompression-based DoS vulnerabilities affecting streaming API and content encoding handling.
✅ Code not affected by breaking changes.
No breaking changes from the urllib3 upgrade affect this codebase. The codebase does not directly use urllib3 or any of the removed methods (
HTTPResponse.getheaders(),HTTPResponse.getheader()), does not implement customContentDecoderclasses, and does not handleContent-Encodingheaders directly. While urllib3 is a transitive dependency, the code only uses higher-level libraries (posthog) that will handle any necessary compatibility updates internally.All breaking changes by upgrading urllib3 from version 2.5.0 to 2.6.3 (CHANGELOG)
HTTPResponse.getheaders()method in favor ofHTTPResponse.headers. Removed theHTTPResponse.getheader(name, default)method in favor ofHTTPResponse.headers.get(name, default).Content-Encodingheader is now limited to 5, which may cause responses with more than 5 chained encodings to fail.urllib3.response.ContentDecoderhas changed, requiring custom decompressors to be updated.✅ 3 CVEs resolved by this upgrade
This PR will resolve the following CVEs: