Feat/tanstack query proof of concept #1146
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnetennba3
force-pushed
the
feat/tanstack-query-proof-of-concept
branch
2 times, most recently
from
0938e5e to
30842d5
Compare
Replacing all uses of `createFetchStore` to use Tanstack Query instead to handle state management. The immediate benefit of this is that we're no longer debouncing each request which is adding an artificial delay of 500ms for each request. I also think the error handling is clearer because its colocated with mutations via onError. There are many more benefits to come with using Tanstack Query, this is just a 1:1 replace to illustrate how it works.
For static data, we should fetch server-side in Astro and pass in to the component.
I thought it was clearer to have everything colated together rather than separate screens in /screens because it's not clear where the logical separation is. I have also adopted the naming conventions we use in the API and database for consistency: - themes > selected themes - generated themes > candidate themes - answers > responses
The main motivations behind this refactor is: - Replacing all instances of `createFetchStore` with either TanStack Query for dynamic data and server-side fetch in Atsro for static data - Breaking down into smaller and better encapsulated components that own the relevant queries, mutations and state - Add disabled state to prevent duplicate reuqests
Centralise API routes, query keys, and data fetching logic into resource-based query files. This removes scattered fetch calls and route helpers from components, making it easier to understand where data comes from and ensuring consistent error handling. Components now import everything they need (types, queries, mutations) from a single query file per resource, reducing cognitive overhead when working with API data.
tnetennba3
force-pushed
the
feat/tanstack-query-proof-of-concept
branch
from
30842d5 to
a3131eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes proposed in this pull request
Guidance to review
Link to Trello ticket
Things to check
.env.testfiles in the repo