Add lens hover effect to target#68
Open
justindantzer wants to merge 4 commits intoi-like-robots:masterfrom
Open
Add lens hover effect to target#68justindantzer wants to merge 4 commits intoi-like-robots:masterfrom
justindantzer wants to merge 4 commits intoi-like-robots:masterfrom
Conversation
css/easyzoom.css
Outdated
Owner
There was a problem hiding this comment.
Don't worry about the prefixes these days http://caniuse.com/#search=box-sizing
Owner
|
Thanks for taking the time to add this feature @justindantzer This is something I've actively avoided implementing - because when using the zoom as the original overlay it makes no sense - but it has been requested a few times now. Pleased to see you've added it behind an option flag and off by default too. Could you please run the JSHint Grunt task over this and amend the commit with any changes required? Thanks again. |
Author
|
@i-like-robots I'm happy to contribute. JSHint completed without errors, lint free. |
css/easyzoom.css
Outdated
Owner
There was a problem hiding this comment.
The top and left properties can be removed as they're specified in the JS anyway
Changed notice from using .text() to .html() and minor edits to default's comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple lens effect option, similar to other image zoom plugins, and can be enabled/disabled with a passed option.