Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
strictNoSuspenseTypeScript option for saferuseTranslationusageFixes #1896
Description
When using
useSuspense: false, forgetting to checkreadybefore accessingtcauses i18n keys to render on the page. This PR adds an optional TypeScript setting that enforces checkingreadybefore usingt.Usage
When
useSuspense: true(default) or whenstrictNoSuspenseis not enabled, behavior remains unchanged.Changes
UseTranslationResponseNotReady,UseTranslationResponseReady, andUseTranslationResponseStricttypes toindex.d.tsuseTranslationthat return discriminated union whenuseSuspense: falseandstrictNoSuspense: truetest/typescript/strict-no-suspense/Checklist
npm run testChecklist (for documentation change)
Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=42954461