Dependency Updates, Modernize Rust Version + Misc Enhancements#18
Open
bonedaddy wants to merge 9 commits intoi2p:masterfrom
Open
Dependency Updates, Modernize Rust Version + Misc Enhancements#18bonedaddy wants to merge 9 commits intoi2p:masterfrom
bonedaddy wants to merge 9 commits intoi2p:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Includes a number of changes that modernize the rust version in use, upgrades all dependencies, and uses better error handling:
2021nom(explained later)failureandfailure_derive, replacing them withanyhowandthiserror0.2.0Nom Upgrade Issues
Between version
6.0.0and7.0.0ofnom, the overall API of the library was significantly changed, such that the currentnomparsers are no longer valid and need to be rewritten. Given that it represents a fairly significant logic change, I've left that out of this PR.