This repository was archived by the owner on Jul 2, 2025. It is now read-only.
* Remove onaudioprocess event handler before processor has been deleted.#1
Merged
* Remove onaudioprocess event handler before processor has been deleted.#1
Conversation
sih4sing5hong5
approved these changes
May 20, 2022
| if (this.isRecording()) { | ||
| this.input.disconnect(); | ||
| this.processor.disconnect(); | ||
| this.processor.onaudioprocess = null; |
Author
There was a problem hiding this comment.
我認為是為著 https://github.com/i3thuan5/web-audio-recorder-js/blob/master/lib/WebAudioRecorder.js#L98-L102 onaudioprocess 內底有送信號 worker.postMessage({ command: "record", buffer: buffer });，叫後壁錄音。
sih4sing5hong5
approved these changes
May 20, 2022
Author
|
另外發現歹消息，套件內底 createScriptProcessor beh pha-sé--ah。
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
因為原底若kā錄音擋起來，console會跳錯誤 "TypeError: recBuffers.push is undefined"。
原專案 PR #37 有人講是 race condition。