fixed #25 (Events are not passed through to the foreground view if STICKY_HEADER_HEIGHT overlaps)#57
Open
naxel wants to merge 1 commit intoi6mi6:masterfrom
Open
fixed #25 (Events are not passed through to the foreground view if STICKY_HEADER_HEIGHT overlaps)#57naxel wants to merge 1 commit intoi6mi6:masterfrom
naxel wants to merge 1 commit intoi6mi6:masterfrom
Conversation
| inputRange: [0, stickyHeaderHeight], | ||
| outputRange: [0, stickyHeaderHeight], | ||
| extrapolate: 'clamp' | ||
| }); |
There was a problem hiding this comment.
Maybe height need to be declared as const, don't see it changing later in code.
Also maybe it could be replaced with call to interpolate in View parameters, similar to opacity
|
I don't get why this PR isn't merged and new release bumped if Readme.md clearly states that the PR are welcome to this project. It has been here more than a half year. |
fungilation
added a commit
to fungilation/react-native-parallax-scroll-view
that referenced
this pull request
Aug 5, 2017
fungilation
added a commit
to fungilation/react-native-parallax-scroll-view
that referenced
this pull request
Aug 5, 2017
patheinen
added a commit
to patheinen/react-native-parallax-scroll-view
that referenced
this pull request
Sep 28, 2017
Owner
|
@naxel Would you resolve the conflict and resubmit the PR? |
flikQ
approved these changes
Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #25 (Events are not passed through to the foreground view if STICKY_HEADER_HEIGHT overlaps)