fix: update XML element retrieval to use correct parent nodes#3811
Merged
iBotPeaches merged 2 commits intoiBotPeaches:masterfrom Mar 3, 2025
Merged
fix: update XML element retrieval to use correct parent nodes#3811iBotPeaches merged 2 commits intoiBotPeaches:masterfrom
iBotPeaches merged 2 commits intoiBotPeaches:masterfrom
Conversation
Handling the case when the network security configs already exist under the <debug-overrides> element. Currently only an empty <base-config> element is added.
iBotPeaches
reviewed
Feb 26, 2025
Owner
iBotPeaches
left a comment
There was a problem hiding this comment.
Is this a mistake that we could cover in this test case? https://github.com/iBotPeaches/Apktool/blob/master/brut.apktool/apktool-lib/src/test/java/brut/androlib/aapt2/NetworkConfigTest.java
Contributor
Author
|
updated the test, please check. |
iBotPeaches
approved these changes
Feb 28, 2025
Owner
|
thanks! |
iBotPeaches
added a commit
that referenced
this pull request
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handling the case when the network security configs already exist under the
<debug-overrides/>element.We should look for the next element under the new element we created/found.
Currently:
Expected:
Example package:
com.tradingview.tradingviewapp