fix: roundtrip XML values containing CDATA-like strings

[vbfox]

This fixes the case where the value (text content) for an XML element that needs to be escaped contains text looking like the ending of a CDATA tag (]]>) as this must be escaped.

Relevant specification: https://www.w3.org/TR/xml/#syntax

In the content of elements, character data is any string of characters which does not contain the start-delimiter of any markup and does not include the CDATA-section-close delimiter, " ]]> ".

[iBotPeaches]

Do you have a sample string from something in the wild that led to this? I understand these samples and description, but trying to piece together with something in the wild to understand the flaw Apktool originally had in escaping.

[vbfox]

@iBotPeaches You can find an example in the french resources of the uber app:

apkeep -a com.ubercab -d google-play -o split_apk=true,locale=fr_FR .
cd com.ubercab
java -jar ~/apktool_2.11.1.jar d com.ubercab.config.fr.apk
cat com.ubercab.config.fr/res/values-fr/strings.xml

This will look something like this:

<?xml version="1.0" encoding="utf-8"?>
<resources> 
    <string name="account_switcher_account_limit_error_modal_message">"&lt;![CDATA[Vous avez atteint la limite de votre compte. Appuyez sur l'icône &lt;b>Gérer&lt;/b> (icône en forme d'engrenage) pour vous déco
  nnecter de l'un de vos comptes avant d'en ajouter un autre.]]>"</string>
</resources>

[iBotPeaches]

Looks good - just a few minor nitpicks.

[vbfox]

Nitpicks should be fixed now

[iBotPeaches]

thanks!