fix: handle arbitrary resources#4066
Closed
PeterKnecht93 wants to merge 1 commit intoiBotPeaches:mainfrom
Closed
Conversation
Signed-off-by: Louis Poier <lpoier7@proton.me>
Collaborator
|
I'm already working on a better way to abstract this issue, PR will be ready soon. |
Collaborator
|
Fixed by #4067 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3615
This fixes resources not being handled if a resource table could not be found, as is currently the case for
framework.jarfiles.The issue is caused by
decodeResources(rightfully) skipping decoding if noresources.arscwas found, but ascopyUnknownFilesignores resources expecting they would be handled by this method, they ultimately just end up being left out. Therefore, this patch adds an extra check incopyUnknownFilesto copy resources as-is if no resource table was found.