fix: wrong radix multipliers for complex values#4070
Closed
huanli233 wants to merge 1 commit intoiBotPeaches:mainfrom
Closed
fix: wrong radix multipliers for complex values#4070huanli233 wants to merge 1 commit intoiBotPeaches:mainfrom
huanli233 wants to merge 1 commit intoiBotPeaches:mainfrom
Conversation
e95d0b3 to
66826ae
Compare
66826ae to
5ff7f24
Compare
Collaborator
|
There's no difference between the code you added and the existing code in Source: Decoded as: Which is normal because |
Author
|
I apologize for my oversight. I was using apktool-lib for decoding in my layoutlib environment, which may have affected apktool's calls to TypedValue. This pull request did resolve the issue, but it was unnecessary. This pull request will be closed. Thank you for your reply. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix incorrect decoding of complex fraction/dimension values in binary XML output.
Why
ResXmlEncoders used wrong radix multipliers, causing some values (e.g. -2%) to be decoded into huge incorrect numbers (e.g. -4294963200%).
How
Use the same MANTISSA_MULT / RADIX_MULTS math as AOSP android.util.TypedValue.complexToFloat().
Result
Decoded XML matches aapt2 / jadx behavior for negative fractions/dimensions.