Fix: Done refactoring rte-helpers #361
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yagth
reviewed
Nov 14, 2025
| $exp)) | ||
| (if (== (get-metatype $exp) Expression) | ||
| (let ($h $t) (decons-atom $exp) | ||
| (eval (if-decons-expr-custom $exp $h $t |
Yagth
reviewed
Nov 14, 2025
| (empty) | ||
| (getLiteralsND $exp)) | ||
| $exp)) | ||
| (if (or (not (== $exp ())) (== (get-metatype $exp) Expression)) |
Collaborator
There was a problem hiding this comment.
Same thing here. Check it out if it works with if-decons-expr-custom only...
| ;; (: concatTuple (-> Expression Expression Expression)) | ||
| (= (concatTuple $x $y) (collapse (union (superpose $x) (superpose $y)))) ;; FIX: No longer working on version 0.2.3 | ||
| (= (concatTuple $x $y) (union-atom $x $y)) | ||
| ; (= (concatTuple $x $y) (collapse (union (superpose $x) (superpose $y)))) ;; FIX: No longer working on version 0.2.3 |
Collaborator
There was a problem hiding this comment.
Suggested change
| ; (= (concatTuple $x $y) (collapse (union (superpose $x) (superpose $y)))) ;; FIX: No longer working on version 0.2.3 |
Collaborator
|
@blackhammer116 I will merge this PR as soon as the conversations are resolved :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Done refactoring
rte-helpersfunctions and also fixed the assertEqual issue in the workflow to handle failing test cases that are designated as a false positive, for that reason ordered-set test file have been renamed back to*testold.metta, also you might see some test cases commented out inside thehelpers-functions-testthat's because it's not related to therte-helpersfile.How Has This Been Tested?
Types of changes
Checklist: