CI/CD Linting + Smoke by iErcann · Pull Request #34 · iErcann/NotBlox

iErcann · 2026-02-26T22:28:28Z

No description provided.

…sts; include health check for TCP port 8001

vercel · 2026-02-26T22:28:33Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
notblox	Ready	Preview, Comment	Feb 26, 2026 10:28pm

Copilot

Pull request overview

Adds CI linting/typecheck and a Docker smoke test, while tightening TypeScript typings around uWebSockets usage in the backend.

Changes:

Add GitHub Actions workflow to lint/type-check the backend and run a Docker build + healthcheck-based smoke test.
Introduce ESLint flat config for the backend and update backend lint scripts/deps.
Improve backend websocket typing by using uWebSockets.js generics and ws.getUserData() instead of any / ws.player.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
pnpm-lock.yaml	Adds/updates ESLint/TS-ESLint/jiti/minimatch-related dependency resolutions.
back/src/scripts/footballScript.ts	Comments out an unused targeted chat helper.
back/src/scripts/defaultScript.ts	Minor TS cleanup in callbacks and variable initialization.
back/src/ecs/system/network/WebsocketSystem.ts	Types websocket handlers and stores player in `getUserData()`; adjusts message parsing and connection handling.
back/src/ecs/system/network/NetworkSystem.ts	Tightens broadcast payload type to `Uint8Array`.
back/src/ecs/entity/Player.ts	Types websocket parameter as `WebSocket<unknown>`.
back/src/ecs/component/WebsocketComponent.ts	Types stored websocket as `WebSocket<unknown>`.
back/package.json	Updates lint scripts, adds ESLint flat-config deps, and adds overrides.
back/eslint.config.ts	Adds new ESLint flat config file for the backend.
Dockerfile	Adds a healthcheck probing TCP port 8001.
.github/workflows/ci.yml	New CI workflow for lint/typecheck + Docker smoke test.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-26T22:36:23Z

back/src/ecs/system/network/WebsocketSystem.ts

    if (await this.isRateLimited(ip)) {
      // Respond to the client indicating that the connection is rate limited
-      return ws.close(429, 'Rate limit exceeded')
+      return ws.close()


onConnect still says it will respond to the client when rate-limited, but now it just calls ws.close() with no close code/reason. If you want clients to handle this, send a meaningful WebSocket close code/reason (valid WS codes are 1000–4999) or reject the upgrade with an HTTP status before upgrading.

Suggested change

return ws.close()

return ws.close(1013, 'Rate limit exceeded')

Copilot · 2026-02-26T22:36:23Z

back/src/ecs/system/network/WebsocketSystem.ts

+    this.addMessageHandler(
+      ClientMessageType.INPUT,
+      this.handleInputMessage.bind(this) as MessageHandler
+    )
+    this.addMessageHandler(


The as MessageHandler casts here weaken type-safety and can hide mismatches between ClientMessageType and the handler payload types. Consider typing the handler map as a discriminated/mapped type keyed by ClientMessageType (or using a switch in onMessage) so handlers can accept their specific message shapes without assertions.

Copilot · 2026-02-26T22:36:23Z

.github/workflows/ci.yml

+      - name: Setup pnpm
+        uses: pnpm/action-setup@v4
+        with:
+          version: latest


CI installs pnpm with version: latest, which can introduce unexpected breakages when pnpm releases new majors/minors. Pin pnpm to a known-good version (or at least a major) to keep CI reproducible with the checked-in lockfile.

Suggested change

version: latest

version: 9

Copilot · 2026-02-26T22:36:23Z

back/src/ecs/system/network/WebsocketSystem.ts

+  WebSocket,
  us_listen_socket,
  us_socket_context_t,
 } from 'uWebSockets.js'


WebSocket appears to be used only as a TypeScript type here. Importing it as a runtime named export ({ WebSocket }) can break at runtime if uWebSockets.js doesn’t actually export WebSocket (many libraries only declare it in .d.ts). Please switch to a type-only import for WebSocket (and keep only runtime exports in the value import).

Suggested change

WebSocket,

us_listen_socket,

us_socket_context_t,

} from 'uWebSockets.js'

us_listen_socket,

us_socket_context_t,

} from 'uWebSockets.js'

import type { WebSocket } from 'uWebSockets.js'

Copilot · 2026-02-26T22:36:23Z

back/eslint.config.ts

+  { files: ["**/*.{js,mjs,cjs,ts,mts,cts}"], plugins: { js }, extends: ["js/recommended"], languageOptions: { globals: globals.browser } },
+  tseslint.configs.recommended,


eslint.config.ts is using flat-config style (defineConfig) but mixes in legacy config fields: plugins: { js } and extends: ["js/recommended"]. @eslint/js exports config objects (e.g. js.configs.recommended) rather than a plugin, and flat config extends should reference config objects (not strings). As written, ESLint 10 will likely fail to load or silently not apply the intended rules—please restructure the config to compose js.configs.recommended + the TypeScript ESLint configs directly.

Suggested change

{ files: ["**/*.{js,mjs,cjs,ts,mts,cts}"], plugins: { js }, extends: ["js/recommended"], languageOptions: { globals: globals.browser } },

tseslint.configs.recommended,

{

...js.configs.recommended,

files: ["**/*.{js,mjs,cjs,ts,mts,cts}"],

languageOptions: {

...js.configs.recommended.languageOptions,

globals: {

...(js.configs.recommended.languageOptions?.globals ?? {}),

...globals.browser,

},

},

},

...tseslint.configs.recommended,

Copilot · 2026-02-26T22:36:24Z

back/eslint.config.ts

+import { defineConfig } from "eslint/config";
+
+export default defineConfig([
+  { files: ["**/*.{js,mjs,cjs,ts,mts,cts}"], plugins: { js }, extends: ["js/recommended"], languageOptions: { globals: globals.browser } },


This backend ESLint config sets languageOptions.globals to globals.browser, which omits Node globals like process/Buffer. That will cause no-undef (or similar) errors throughout the server code. Use Node (or a merge of Node + ES globals) for backend files, and only apply browser globals to frontend code if needed.

Suggested change

{ files: ["**/*.{js,mjs,cjs,ts,mts,cts}"], plugins: { js }, extends: ["js/recommended"], languageOptions: { globals: globals.browser } },

{ files: ["**/*.{js,mjs,cjs,ts,mts,cts}"], plugins: { js }, extends: ["js/recommended"], languageOptions: { globals: globals.node } },

Copilot · 2026-02-26T22:36:24Z

back/eslint.config.ts

+import js from "@eslint/js";
+import globals from "globals";
+import tseslint from "typescript-eslint";
+import { defineConfig } from "eslint/config";
+
+export default defineConfig([
+  { files: ["**/*.{js,mjs,cjs,ts,mts,cts}"], plugins: { js }, extends: ["js/recommended"], languageOptions: { globals: globals.browser } },
+  tseslint.configs.recommended,
+]);


The new TS config file doesn’t follow the repository’s Prettier settings (single quotes, no semicolons, line width). This will introduce avoidable formatting diffs when the file is auto-formatted. Please run Prettier (or adjust the file) to match .prettierrc.

Suggested change

import js from "@eslint/js";

import globals from "globals";

import tseslint from "typescript-eslint";

import { defineConfig } from "eslint/config";

export default defineConfig([

{ files: ["**/*.{js,mjs,cjs,ts,mts,cts}"], plugins: { js }, extends: ["js/recommended"], languageOptions: { globals: globals.browser } },

tseslint.configs.recommended,

]);

import js from '@eslint/js'

import globals from 'globals'

import tseslint from 'typescript-eslint'

import { defineConfig } from 'eslint/config'

export default defineConfig([

{

files: ['**/*.{js,mjs,cjs,ts,mts,cts}'],

plugins: { js },

extends: ['js/recommended'],

languageOptions: { globals: globals.browser },

},

tseslint.configs.recommended,

])

Copilot · 2026-02-26T22:36:24Z

back/package.json

  "overrides": {
-    "minimatch": "^10.2.1"
+    "minimatch": "^10.2.1",
+    "jiti": "latest"


jiti is overridden to "latest", which makes installs non-reproducible and can break CI unexpectedly when a new major is released. Prefer pinning to a specific version/range (matching the lockfile) or removing the override unless there’s a concrete compatibility need.

Suggested change

"jiti": "latest"

"jiti": "^2.6.1"

Copilot · 2026-02-26T22:36:24Z

back/src/ecs/system/network/WebsocketSystem.ts

    this.addMessageHandler(
      ClientMessageType.PROXIMITY_PROMPT_INTERACT,
-      this.handleProximityPromptInteractMessage.bind(this)
+      this.handleProximityPromptInteractMessage.bind(this) as MessageHandler
    )
    this.addMessageHandler(


These casts to MessageHandler remove compile-time guarantees that the handler matches the message type. A typed handler map keyed by ClientMessageType would keep this safe without as assertions.

Copilot · 2026-02-26T22:36:24Z

back/src/ecs/system/network/WebsocketSystem.ts

    this.addMessageHandler(
      ClientMessageType.SET_PLAYER_NAME,
-      this.handleSetPlayerNameMessage.bind(this)
+      this.handleSetPlayerNameMessage.bind(this) as MessageHandler
    )
  }


Same issue as above: the as MessageHandler casts hide mismatches between the message discriminator and the handler signature. Prefer a typed mapping (or narrowing in onMessage) so the compiler enforces correct handler/message pairing.

iErcann added 2 commits February 24, 2026 23:58

feat: add CI workflow for linting, type-checking, and Docker smoke te…

fc00765

…sts; include health check for TCP port 8001

refactor(types): better typing + linting issues fixed

d69030f

iErcann requested a review from Copilot February 26, 2026 22:28

Copilot started reviewing on behalf of iErcann February 26, 2026 22:29 View session

iErcann merged commit b1cf6da into main Feb 26, 2026
8 checks passed

Copilot AI reviewed Feb 26, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI/CD Linting + Smoke #34

CI/CD Linting + Smoke #34
iErcann merged 2 commits intomainfrom
smoke

iErcann commented Feb 26, 2026

Uh oh!

vercel bot commented Feb 26, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	return ws.close()
	return ws.close(1013, 'Rate limit exceeded')

		{ files: ["*/.{js,mjs,cjs,ts,mts,cts}"], plugins: { js }, extends: ["js/recommended"], languageOptions: { globals: globals.browser } },
		tseslint.configs.recommended,

-  { files: ["**/*.{js,mjs,cjs,ts,mts,cts}"], plugins: { js }, extends: ["js/recommended"], languageOptions: { globals: globals.browser } },
-  tseslint.configs.recommended,
+  {
+    ...js.configs.recommended,
+    files: ["**/*.{js,mjs,cjs,ts,mts,cts}"],
+    languageOptions: {
+      ...js.configs.recommended.languageOptions,
+      globals: {
+        ...(js.configs.recommended.languageOptions?.globals ?? {}),
+        ...globals.browser,
+      },
+    },
+  },
+  ...tseslint.configs.recommended,

Conversation

iErcann commented Feb 26, 2026

Uh oh!

vercel bot commented Feb 26, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants