migrate 200 IT file #164
migrate 200 IT file #164
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #164 +/- ##
========================================
Coverage 84.67% 84.67%
========================================
Files 35 35
Lines 1083 1083
Branches 221 221
========================================
Hits 917 917
Misses 166 166 ☔ View full report in Codecov by Sentry. |
test/200_fullchain-bot.test.ts
Outdated
| ], | ||
| 2: [ | ||
| { worker: worker1, useEnclave: false, result: 'iExec BOT 2' }, | ||
| { worker: worker3, useEnclave: false, result: '<timeout reached>' }, |
There was a problem hiding this comment.
| { worker: worker3, useEnclave: false, result: '<timeout reached>' }, | |
| { worker: worker3, useEnclave: false, result: '<reveal timeout reached>' }, |
?
To make it more precise.
There was a problem hiding this comment.
Actually it's not releated to a reveal timeout. Since it's a bad contribution when the trust contribution is reached the reveal of bad result would failed
There was a problem hiding this comment.
Why not <bad contribution> then?
There was a problem hiding this comment.
Perfect, makes sense
test/200_fullchain-bot.test.ts
Outdated
| const workerRewardPerTask = await iexecWrapper.computeWorkerRewardPerTask( | ||
| dealId, | ||
| PocoMode.CLASSIC, | ||
| ); |
There was a problem hiding this comment.
| const workerRewardPerTask = await iexecWrapper.computeWorkerRewardPerTask( | |
| dealId, | |
| PocoMode.CLASSIC, | |
| ); | |
| const workersRewardPerTask = await iexecWrapper.computeWorkersRewardPerTask( | |
| dealId, | |
| PocoMode.CLASSIC, | |
| ); |
We probably need to rename it in other files.
There was a problem hiding this comment.
Will rename it in the next PR that will concern the 000 fullchain test file thanks
| ); | ||
| } | ||
| }); | ||
| async function getInitialFrozens(accounts: SignerWithAddress[]) { |
There was a problem hiding this comment.
This function can be extracted in a common file.
No description provided.