-
Notifications
You must be signed in to change notification settings - Fork 14
Sunset Jenkins pipeline #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9df2877
Pin nodejs version in Github actions
zguesmi 394f431
Add missing steps from Jenkinsfile
zguesmi 54c2824
Remove Jenkinsfile
zguesmi 4e1a202
Update changelog
zguesmi 4beca81
Fix CI
zguesmi 8fb6ba3
Apply review suggestions
zguesmi 5224c77
Merge branch 'develop' into feature/jenkins-ci-sunset
zguesmi 967ad9e
Test Slither action with new sarif filename
zguesmi 419280f
Debug CI issue
zguesmi 9c2d024
Debug CI issue
zguesmi 329cbcd
Debug CI issue
zguesmi df28050
Merge branch 'develop' into feature/jenkins-ci-sunset
zguesmi 156ef47
Debug CI issue
zguesmi e8b9cd5
Fix CI
zguesmi 75f0084
Use setup node action v4
zguesmi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,31 +10,48 @@ on: | |
| - v5 | ||
|
|
||
| jobs: | ||
| # Note: changing the name of the job disables Slither checks with the error: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice finding ! |
||
| # Warning: Code scanning cannot determine the alerts introduced by this pull | ||
| # request, because 1 configuration present on refs/heads/develop was not found: | ||
| # | ||
| # Actions workflow (main.yml) | ||
| # ❓ .github/workflows/main.yml:coverage | ||
| coverage: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - name: Init | ||
| - name: Set up Nodejs | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20 | ||
| cache: 'npm' # Cache dependencies | ||
| - name: Install dependencies | ||
| run: npm ci | ||
| - name: Build | ||
| run: npm run build | ||
| - name: Check storage layout | ||
| run: npm run test-storage-layout | ||
| - name: Run deployment | ||
| # Basic deployment to make sure everything is ok. | ||
| # Could be removed in the future if not relevant. | ||
| run: npm run deploy | ||
| - name: Run coverage | ||
| run: npm run coverage | ||
| - name: Upload coverage reports to Codecov | ||
| uses: codecov/[email protected] | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| slug: iExecBlockchainComputing/PoCo | ||
| - name: Run static analysis with slither | ||
| - name: Run static analysis with Slither | ||
zguesmi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| uses: crytic/[email protected] | ||
| id: slither | ||
| with: | ||
| target: "contracts/tools/testing/slither/" | ||
| solc-version: '0.8.21' | ||
| slither-args: --checklist --markdown-root ${{ github.server_url }}/${{ github.repository }}/blob/${{ github.sha }}/ | ||
| node-version: "20" | ||
| fail-on: none # TODO set this to high or other | ||
| sarif: results.sarif | ||
| - name: Upload SARIF file | ||
| uses: github/codeql-action/upload-sarif@v3 | ||
| with: | ||
| sarif_file: ${{ steps.slither.outputs.sarif }} | ||
| sarif_file: results.sarif | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.