Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
f34d071
feat: Update IexecPocoAccessorsFacet and related scripts for enhanced…
gfournierPro Sep 18, 2025
4a44957
feat: Remove useless file
gfournierPro Sep 22, 2025
99b1b47
feat: Refactor deal and task accessors in IexecPocoAccessorsFacet
gfournierPro Sep 22, 2025
be36a3a
feat: Update Arbitrum RPC URL in Hardhat configuration
gfournierPro Sep 22, 2025
7c7fe07
feat: move new upgrades scripts in accessors subfolder
gfournierPro Sep 22, 2025
8b261fd
feat: refactor deployment script for IexecPocoAccessorsFacet
gfournierPro Sep 22, 2025
b27b116
feat: change to pure instead of view
gfournierPro Sep 22, 2025
9e1d7eb
feat: remove commented code for IexecAccessorsFacet in deploy script
gfournierPro Sep 22, 2025
27f02ab
Merge branch 'main' into feature/new-viewer-fct
Le-Caignec Sep 22, 2025
2939683
feat: remove blockNumber configuration for Arbitrum forking
gfournierPro Sep 22, 2025
99acad3
fix: remove commented code in update proxy script for IexecPocoAccess…
gfournierPro Sep 22, 2025
359d32c
refactor: remove unused functionsToRemove array in update proxy script
gfournierPro Sep 22, 2025
aa5d0e1
refactor: remove deployment record update for IexecPocoAccessorsFacet…
gfournierPro Sep 22, 2025
cc99fa1
feat: implement deployment and update logic for IexecPocoAccessorsFac…
gfournierPro Sep 22, 2025
ce727e7
refactor: simplify old accessor facets identification in deploy script
gfournierPro Sep 22, 2025
22b517e
refactor: update variable names for clarity in deploy and update scri…
gfournierPro Sep 22, 2025
78d8a97
refactor: replace function selector retrieval with linkContractToProx…
gfournierPro Sep 22, 2025
706cbb0
fix: add boundary check for category index in viewCategory function a…
gfournierPro Sep 23, 2025
5033eb9
refactor: remove unnecessary local fork block mining in deploy script…
gfournierPro Sep 23, 2025
f4204dc
refactor: streamline diamond proxy interaction and enhance logging in…
gfournierPro Sep 23, 2025
49a5e4b
refactor: simplify old accessor facets removal logic in deploy script…
gfournierPro Sep 23, 2025
c46526a
refactor: update proxy owner signer logic to conditionally use impers…
gfournierPro Sep 23, 2025
b1105fd
fix: ensure retro-compatibility by reverting without reason in viewCa…
gfournierPro Sep 23, 2025
999aac0
refactor: fix log message formatting and enhance removal logging for …
gfournierPro Sep 23, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions contracts/facets/IexecPocoAccessorsFacet.sol
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,9 @@ contract IexecPocoAccessorsFacet is
uint256 _catid
) external view returns (IexecLibCore_v5.Category memory category) {
PocoStorageLib.PocoStorage storage $ = PocoStorageLib.getPocoStorage();
if (_catid >= $.m_categories.length) {
revert();
}
return $.m_categories[_catid];
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ describe('CategoryManager', async () => {
const lastCategoryIndex = (await iexecPocoAsAnyone.countCategory()) - 1n;
await expect(
iexecPocoAsAnyone.viewCategory(lastCategoryIndex + 1n),
).to.be.revertedWithPanic(0x32);
).to.be.revertedWithoutReason();
});

it('Should create category', async () => {
Expand Down