-
Notifications
You must be signed in to change notification settings - Fork 14
refactor: replace IexecAccessors with IexecPocoAccessors in tests #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… functionality and proxy updates
… in proxy upgrade script
…xecPocoAccessorsFacet
… mapping in deploy script
…pt for IexecPocoAccessorsFacet
…y for new facet integration
…O comment for migration
…loy-and-update-accessor-facet script
…tions in deploy-and-update-accessor-facet script
… deploy-and-update-accessor-facet script
…ccessors interface
…sulate constant function removal for
…yment, scripts, and tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Refactors test files to replace IexecAccessors with IexecPocoAccessors throughout the test suite and utility functions. This aligns the tests with the updated architecture while maintaining the same testing functionality.
- Replace all
IexecAccessors__factoryimports and usages withIexecPocoAccessors__factory - Update variable names from
iexecAccessortoiexecPocoAccessorfor consistency - Modify deployment and script files to use the new accessor class
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/utils/IexecWrapper.ts | Updates utility class to use IexecPocoAccessors instead of IexecAccessors |
| test/byContract/iexecPocoAccessors/IexecPocoAccessors.test.ts | Replaces all test calls to use iexecPocoAccessors instance |
| test/byContract/IexecPocoBoost/IexecPocoBoost.test.ts | Updates boost tests to use IexecPocoAccessors throughout |
| test/000_fullchain-boost.test.ts | Changes fullchain integration test to use new accessor |
| scripts/set-callback-gas.ts | Updates script to use IexecPocoAccessors for configuration |
| deploy/0_deploy.ts | Modifies deployment script to use updated accessor class |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
==========================================
+ Coverage 83.66% 84.56% +0.90%
==========================================
Files 38 37 -1
Lines 1218 1218
Branches 227 227
==========================================
+ Hits 1019 1030 +11
+ Misses 199 188 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
deployment, scripts, and tests