feat: implement dataset compatibility check with a deal in IexecPoco1Facet

[Le-Caignec]

Added a new public view function isDatasetCompatibleWithDeal to verify the compatibility of a dataset order with a deal. This function includes multiple checks such as deal existence, dataset order owner signature, and restrictions on app, workerpool, and requester. Removed the Matching struct from IexecPoco1Facet and moved it to the IexecPoco1 interface.

To test

1. In one terminal:

ARBITRUM_FORK=true npx hardhat node --no-deploy

1. In another terminal :

ARBITRUM_FORK=true npx hardhat run scripts/upgrades/deploy-and-update-some-facet.ts --network external-hardhat

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.83%. Comparing base (f7c634b) to head (b98a455).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
+ Coverage   83.66%   84.83%   +1.17%     
==========================================
  Files          38       37       -1     
  Lines        1218     1240      +22     
  Branches      227      235       +8     
==========================================
+ Hits         1019     1052      +33     
+ Misses        199      188      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull Request Overview

This PR implements a new dataset compatibility check feature by adding the isDatasetCompatibleWithDeal function to verify if a dataset order can be used with an existing deal. The function validates multiple compatibility criteria including deal existence, dataset order signatures, and restriction matching.

Key changes:

• Added isDatasetCompatibleWithDeal public view function in IexecPoco1Facet
• Moved Matching struct from facet implementation to interface for better organization
• Updated deployment script to handle both IexecPocoAccessorsFacet and IexecPoco1Facet upgrades

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
contracts/facets/IexecPoco1Facet.sol	Adds isDatasetCompatibleWithDeal function and removes Matching struct
contracts/interfaces/IexecPoco1.v8.sol	Adds Matching struct and isDatasetCompatibleWithDeal function signature
test/byContract/IexecPoco/IexecPoco1.test.ts	Comprehensive test suite for the new compatibility function
scripts/upgrades/deploy-and-update-some-facet.ts	Updates deployment script to handle IexecPoco1Facet upgrade

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[gfournierPro]

We should check if we want to return it false (Pierre) or if we want revert( JB)

[Le-Caignec]

Even if the spec changes, I think we should make those changes in another PR and iterate from there.

[Copilot]

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The IexecPocoAccessorsFacet__factory is instantiated twice - once assigned to iexecPocoAccessorsFacetFactory and again in the deployContract call. Use the existing iexecPocoAccessorsFacetFactory variable instead of creating a new instance.

Suggested change

	new IexecPocoAccessorsFacet__factory(iexecLibOrders),
	iexecPocoAccessorsFacetFactory,

[Copilot]

[nitpick] The contract declaration formatting was changed from multi-line to single-line. While this works, the multi-line format is more readable for contracts with multiple inheritance, especially when the line becomes long.

Suggested change

	contract IexecPoco1Facet is IexecPoco1, FacetBase, IexecEscrow, SignatureVerifier, IexecPocoCommon {
	contract IexecPoco1Facet is
	IexecPoco1,
	FacetBase,
	IexecEscrow,
	SignatureVerifier,
	IexecPocoCommon
	{

[zguesmi]

Well done!
Some minor comments but all good.