Skip to content

Conversation

@gfournierPro
Copy link
Contributor

@gfournierPro gfournierPro commented Nov 3, 2025

Replace PR #304

Copilot AI review requested due to automatic review settings November 3, 2025 09:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Hardhat development environment to newer versions and refines the storage layout compatibility checks to support RLC faucet contract dependencies.

  • Updated Hardhat from 2.22.18 to 2.26.5 and added hardhat-verify plugin
  • Upgraded Solidity compiler version for RLC contracts from 0.4.11 to 0.4.24
  • Excluded rlc-faucet-contract from storage layout compatibility checks

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
scripts/check-storage.ts Added filter to skip rlc-faucet-contract files from storage compatibility validation
package.json Updated hardhat to 2.26.5 and added @nomicfoundation/hardhat-verify dependency
package-lock.json Updated dependency tree for hardhat 2.26.5 and new dependencies
hardhat.config.ts Updated RLC contracts compiler version from 0.4.11 to 0.4.24

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

if (!output.sources[src].ast) continue;

// Skip contracts from rlc-faucet-contract
if (src.includes('rlc-faucet-contract/')) {
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The substring check using includes() may inadvertently skip files with 'rlc-faucet-contract/' anywhere in the path. Consider using a more precise check such as src.startsWith('node_modules/rlc-faucet-contract/') or checking against a normalized path to ensure only the intended dependency files are excluded.

Suggested change
if (src.includes('rlc-faucet-contract/')) {
if (src.startsWith('node_modules/rlc-faucet-contract/')) {

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings November 3, 2025 09:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

{ version: '0.8.21', settings: v8Settings }, // PoCo Boost
{ version: '0.6.12', settings }, // PoCo contracts
{ version: '0.4.11', settings }, // RLC contracts
{ version: '0.4.24', settings }, // RLC contracts
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The comment states 'RLC contracts' but the code change shows this is specifically for rlc-faucet-contract (based on the skip logic added in check-storage.ts). Consider updating the comment to be more specific, e.g., '// RLC faucet contract' to clarify which contracts use this compiler version.

Suggested change
{ version: '0.4.24', settings }, // RLC contracts
{ version: '0.4.24', settings }, // RLC faucet contract

Copilot uses AI. Check for mistakes.
@gfournierPro gfournierPro marked this pull request as ready for review November 3, 2025 09:47
Copilot AI review requested due to automatic review settings November 3, 2025 09:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.53%. Comparing base (b277aa0) to head (8d59520).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #313   +/-   ##
=======================================
  Coverage   96.53%   96.53%           
=======================================
  Files          32       32           
  Lines        1069     1069           
  Branches      213      213           
=======================================
  Hits         1032     1032           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI review requested due to automatic review settings November 3, 2025 14:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gfournierPro gfournierPro merged commit 091319a into main Nov 4, 2025
4 checks passed
@gfournierPro gfournierPro deleted the feat/upgrade-hardhat branch November 4, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants