Skip to content

Conversation

@gfournierPro
Copy link
Contributor

Runned
npm run format and added the auto solidity docs

Copilot AI review requested due to automatic review settings November 6, 2025 14:56
@gfournierPro gfournierPro changed the title Fix/format sc fix: format sc Nov 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR applies code formatting improvements to the codebase, focusing on standardizing code style across multiple files. The changes include indentation normalization, quote style consistency, and documentation reorganization.

Key changes:

  • Standardized indentation from 2 spaces to 4 spaces in proxy contracts
  • Converted single quotes to double quotes in import statements
  • Reorganized API documentation for better structure
  • Removed extraneous blank lines

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
docs/solidity/index.md Reorganized documentation structure by moving IexecInterfaceNative section to appear after related interfaces
contracts/registries/proxy/Proxy.sol Standardized indentation to 4 spaces and reformatted assembly blocks
contracts/registries/proxy/InitializableUpgradeabilityProxy.sol Converted import quotes to double quotes and standardized indentation
contracts/registries/proxy/BaseUpgradeabilityProxy.sol Converted import quotes to double quotes and standardized indentation
contracts/registries/proxy/Address.sol Reformatted assembly block with proper indentation
contracts/facets/IexecEscrowNativeFacet.sol Removed extraneous blank line after contract declaration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.32%. Comparing base (f30ad4a) to head (69ebbcd).
⚠️ Report is 1 commits behind head on chore/solidity-v8.

Files with missing lines Patch % Lines
...racts/registries/proxy/BaseUpgradeabilityProxy.sol 70.00% 3 Missing ⚠️
contracts/registries/proxy/Proxy.sol 88.88% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           chore/solidity-v8     #317   +/-   ##
==================================================
  Coverage              96.32%   96.32%           
==================================================
  Files                     34       34           
  Lines                   1117     1117           
  Branches                 209      223   +14     
==================================================
  Hits                    1076     1076           
  Misses                    41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI review requested due to automatic review settings November 6, 2025 16:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 7, 2025 08:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gfournierPro gfournierPro marked this pull request as ready for review November 7, 2025 08:56
@gfournierPro gfournierPro requested a review from zguesmi as a code owner November 7, 2025 08:56
@zguesmi zguesmi changed the title fix: format sc docs: Update docs and run formatter Nov 7, 2025
@zguesmi zguesmi changed the title docs: Update docs and run formatter style: Run formatter Nov 7, 2025
@gfournierPro gfournierPro merged commit a8d8779 into chore/solidity-v8 Nov 7, 2025
11 of 12 checks passed
@gfournierPro gfournierPro deleted the fix/format-sc branch November 7, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants