fix: fix doc #322
Merged
fix: fix doc #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… IApp, IDataset, and IWorkerpool
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes the Solidity documentation by moving interface definitions (IApp, IDataset, IWorkerpool) to appear earlier in the document and adds missing documentation for FacetBase and IexecERC20Base. It also clarifies the receiveApproval function description.
- Moved IApp, IDataset, and IWorkerpool interface documentation to an earlier section
- Added documentation for FacetBase and IexecERC20Base interfaces
- Updated the
receiveApprovalfunction description to mention deposit functionality
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ``` | ||
|
|
||
| Receives approval and optionally matches orders in one transaction | ||
| Receives approval, deposit and optionally matches orders in one transaction |
There was a problem hiding this comment.
Missing comma after 'approval' creates a comma splice. Should be 'Receives approval and deposit, and optionally matches orders in one transaction' or 'Receives approval, processes deposit, and optionally matches orders in one transaction'.
Suggested change
| Receives approval, deposit and optionally matches orders in one transaction | |
| Receives approval, deposit, and optionally matches orders in one transaction |
gfournierPro
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run
npm run doc