Skip to content

Conversation

@gfournierPro
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings November 12, 2025 13:25
@gfournierPro gfournierPro changed the base branch from main to chore/solidity-v8 November 12, 2025 13:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation generation command and performs a major migration of the codebase from Solidity 0.6 to 0.8, along with upgrading OpenZeppelin contracts from v3.3.0 to v5.0.2. The changes also introduce atomic deposit-and-match functionality for the escrow token system.

Key changes:

  • Enhanced documentation generation command to include clean and build steps
  • Upgraded OpenZeppelin contracts to v5.0.2, removing deprecated @iexec/interface and @iexec/solidity dependencies
  • Added atomic deposit+order matching functionality via receiveApproval in IexecEscrowTokenFacet
  • Migrated contracts, tests, and utilities from Solidity 0.6 to 0.8 with proper safety checks

Reviewed Changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Updated doc generation command and upgraded OpenZeppelin to v5.0.2
utils/odb-tools.ts Added encodeOrders utility for encoding order structs
test/byContract/IexecEscrow/IexecEscrowToken.receiveApproval.test.ts Comprehensive tests for new receiveApproval functionality
contracts/facets/IexecEscrowTokenFacet.sol Implemented atomic deposit+match orders feature with delegatecall
contracts/libs/PocoStorageLib.sol Unified storage library, migrated to Solidity 0.8
contracts/registries/* Migrated registry contracts to Solidity 0.8 with OpenZeppelin v5
contracts/interfaces/* Updated interfaces to Solidity 0.8 syntax
hardhat.config.ts Updated compiler comments and import paths
test/000_fullchain-boost.test.ts Updated import to use IWorkerpool__factory
deploy/0_deploy.ts Fixed Ownable import path

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.36%. Comparing base (25c5720) to head (2a7c8c4).
⚠️ Report is 1 commits behind head on chore/solidity-v8.

Additional details and impacted files
@@                Coverage Diff                 @@
##           chore/solidity-v8     #324   +/-   ##
==================================================
  Coverage              96.36%   96.36%           
==================================================
  Files                     34       34           
  Lines                   1127     1127           
  Branches                 213      227   +14     
==================================================
  Hits                    1086     1086           
  Misses                    41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But Ci will make npm run build twice

@gfournierPro gfournierPro merged commit ba6c57d into chore/solidity-v8 Nov 12, 2025
4 checks passed
@gfournierPro gfournierPro deleted the fix/update-generate-doc branch November 12, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants