-
Notifications
You must be signed in to change notification settings - Fork 14
fix: update generate doc command #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the documentation generation command and performs a major migration of the codebase from Solidity 0.6 to 0.8, along with upgrading OpenZeppelin contracts from v3.3.0 to v5.0.2. The changes also introduce atomic deposit-and-match functionality for the escrow token system.
Key changes:
- Enhanced documentation generation command to include clean and build steps
- Upgraded OpenZeppelin contracts to v5.0.2, removing deprecated @iexec/interface and @iexec/solidity dependencies
- Added atomic deposit+order matching functionality via
receiveApprovalin IexecEscrowTokenFacet - Migrated contracts, tests, and utilities from Solidity 0.6 to 0.8 with proper safety checks
Reviewed Changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated doc generation command and upgraded OpenZeppelin to v5.0.2 |
| utils/odb-tools.ts | Added encodeOrders utility for encoding order structs |
| test/byContract/IexecEscrow/IexecEscrowToken.receiveApproval.test.ts | Comprehensive tests for new receiveApproval functionality |
| contracts/facets/IexecEscrowTokenFacet.sol | Implemented atomic deposit+match orders feature with delegatecall |
| contracts/libs/PocoStorageLib.sol | Unified storage library, migrated to Solidity 0.8 |
| contracts/registries/* | Migrated registry contracts to Solidity 0.8 with OpenZeppelin v5 |
| contracts/interfaces/* | Updated interfaces to Solidity 0.8 syntax |
| hardhat.config.ts | Updated compiler comments and import paths |
| test/000_fullchain-boost.test.ts | Updated import to use IWorkerpool__factory |
| deploy/0_deploy.ts | Fixed Ownable import path |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chore/solidity-v8 #324 +/- ##
==================================================
Coverage 96.36% 96.36%
==================================================
Files 34 34
Lines 1127 1127
Branches 213 227 +14
==================================================
Hits 1086 1086
Misses 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But Ci will make npm run build twice
No description provided.