-
Notifications
You must be signed in to change notification settings - Fork 14
chore: Save upgrade artifacts - arbitrum #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Save upgrade artifacts - arbitrum #327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Arbitrum deployment artifacts following a smart contract upgrade. The upgrade consolidates accessor functions and adds dataset order validation.
Key changes:
- Consolidated
IexecAccessorsFacetintoIexecPocoAccessorsFacet, reducing total facet count from 15 to 14 - Standardized constant function naming from UPPERCASE to lowercase_with_underscores
- Added dataset order compatibility validation to
IexecPoco1Facet
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| deployments/arbitrum/IexecPocoAccessorsFacet.json | Updated with new address, consolidated accessor functions, standardized naming conventions, and changed constant getters to pure stateMutability |
| deployments/arbitrum/IexecPoco1Facet.json | Updated with new address, added IncompatibleDatasetOrder error and assertDatasetDealCompatibility function, removed deprecated constant getters |
| deployments/arbitrum/IexecAccessorsFacet.json | Removed as functions were consolidated into IexecPocoAccessorsFacet |
| deployments/arbitrum/.diamond.log | Updated to reflect facet consolidation (15→14 facets, 102→98 functions) and new function mappings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
=======================================
Coverage 96.53% 96.53%
=======================================
Files 32 32
Lines 1069 1069
Branches 199 213 +14
=======================================
Hits 1032 1032
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Le-Caignec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve
Thanks github