Skip to content

Conversation

@gfournierPro
Copy link
Contributor

Thanks github

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Arbitrum deployment artifacts following a smart contract upgrade. The upgrade consolidates accessor functions and adds dataset order validation.

Key changes:

  • Consolidated IexecAccessorsFacet into IexecPocoAccessorsFacet, reducing total facet count from 15 to 14
  • Standardized constant function naming from UPPERCASE to lowercase_with_underscores
  • Added dataset order compatibility validation to IexecPoco1Facet

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
deployments/arbitrum/IexecPocoAccessorsFacet.json Updated with new address, consolidated accessor functions, standardized naming conventions, and changed constant getters to pure stateMutability
deployments/arbitrum/IexecPoco1Facet.json Updated with new address, added IncompatibleDatasetOrder error and assertDatasetDealCompatibility function, removed deprecated constant getters
deployments/arbitrum/IexecAccessorsFacet.json Removed as functions were consolidated into IexecPocoAccessorsFacet
deployments/arbitrum/.diamond.log Updated to reflect facet consolidation (15→14 facets, 102→98 functions) and new function mappings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.53%. Comparing base (001a6a6) to head (6cd3f2f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #327   +/-   ##
=======================================
  Coverage   96.53%   96.53%           
=======================================
  Files          32       32           
  Lines        1069     1069           
  Branches      199      213   +14     
=======================================
  Hits         1032     1032           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@gfournierPro gfournierPro merged commit 5ec3166 into main Nov 13, 2025
4 checks passed
@gfournierPro gfournierPro deleted the chore/save-upgrade-artifacts-arbitrum-19333469855 branch November 13, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants