chore: update dependencies and add ESLint configuration#430

Merged

Le-Caignec merged 3 commits intodevelopfrom

feature/update-dep

Apr 23, 2025

Contributor

Le-Caignec commented Apr 23, 2025

Bump versions of devDependencies including hardhat, solhint, eslint, prettier, and others.
Add .prettierignore file to exclude specific file types from formatting.
Introduce ESLint configuration file with recommended settings and custom rules for scripts and tests.
Add zod for env vralidation


          chore: update dependencies and add ESLint configuration

2c9e739

- Bump versions of devDependencies including hardhat, solhint, eslint, prettier, and others.
- Add .prettierignore file to exclude specific file types from formatting.
- Introduce ESLint configuration file with recommended settings and custom rules for scripts and tests.

Le-Caignec self-assigned this

Le-Caignec and others added 2 commits

April 23, 2025 17:09


          Refactor test utilities and handlers for improved readability and con…

9ae3994

…sistency

- Updated formatting in loadFixture.test.js for better code structure and readability.
- Enhanced getEventFromLogs function in utils.js for clarity.
- Reformatted Invariant.t.sol to improve code legibility.
- Refactored HandlerCollection.sol to enhance readability and maintainability.
- Improved HandlerGlobal.sol by restructuring constant declarations for clarity.
- Refined HandlerRenting.sol to enhance code readability.
- Enhanced HandlerSale.sol for better code structure.
- Improved HandlerSubscription.sol for clarity and consistency.
- Updated storage-to-diagrams.js to include eslint-disable comment for unused vars.
- Removed .eslintignore file and integrated ignore patterns into eslint.config.mjs for better configuration management.


          Merge branch 'develop' into feature/update-dep

c4243c5

Le-Caignec merged commit 693fb24 into develop

3 of 4 checks passed

Le-Caignec deleted the feature/update-dep branch

April 23, 2025 15:11

github-advanced-security bot found potential problems

View reviewed changes

packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

@@ -205,7 +217,12 @@ contract DataProtectorSharing is

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter DataProtectorSharing.getProtectedDataRenter(address,address)._protectedData is not in mixedCase

packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

		@@ -205,7 +217,12 @@ contract DataProtectorSharing is
		}

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter DataProtectorSharing.getProtectedDataRenter(address,address)._renterAddress is not in mixedCase

packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

+                      bytes calldata _extraData
+                  ) public returns (bool) {
                       if (msg.sender != address(POCO_DELEGATE)) {
                           revert OnlyPocoCallerAuthorized(msg.sender);

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter DataProtectorSharing.receiveApproval(address,uint256,address,bytes)._sender is not in mixedCase

packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

		@@ -229,7 +246,10 @@ contract DataProtectorSharing is
		_rentProtectedData(protectedData, _sender, rentingParams);

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter DataProtectorSharing.receiveApproval(address,uint256,address,bytes)._extraData is not in mixedCase

packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

@@ -405,7 +436,10 @@ contract DataProtectorSharing is

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter DataProtectorSharing.setSubscriptionParams(uint256,ISubscription.SubscriptionParams)._collectionTokenId is not in mixedCase

packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

		@@ -405,7 +436,10 @@ contract DataProtectorSharing is
		}

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter DataProtectorSharing.setSubscriptionParams(uint256,ISubscription.SubscriptionParams)._subscriptionParams is not in mixedCase

packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

@@ -436,14 +470,23 @@ contract DataProtectorSharing is

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter DataProtectorSharing.setProtectedDataToRenting(address,IRental.RentingParams)._protectedData is not in mixedCase

packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

		@@ -436,14 +470,23 @@ contract DataProtectorSharing is
		return _buyProtectedData(_protectedData, msg.sender, _to, _price);

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter DataProtectorSharing.setProtectedDataToRenting(address,IRental.RentingParams)._rentingParams is not in mixedCase

packages/sharing-smart-contract/contracts/registry/AddOnlyAppWhitelist.sol

Comment on lines +25 to +26

		AddOnlyAppWhitelistRegistry public immutable APP_WHITELIST_REGISTRY =
		AddOnlyAppWhitelistRegistry(msg.sender);

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Variable AddOnlyAppWhitelist.APP_WHITELIST_REGISTRY is not in mixedCase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet