feat(sharing): Deploy DPS contract using Github action #443
Conversation
| strategyConfig: { | ||
| create2: { | ||
| salt: "0x0000000000000000000000000000000000000000000000000000000000000000", | ||
| salt: "0x5FD8F2C3DFCF36E174AC91A44AE6CAEBDDA012EFED601736E2C20A11A56CF532", |
There was a problem hiding this comment.
Reset salt and deploy before merging
| salt: "0x5FD8F2C3DFCF36E174AC91A44AE6CAEBDDA012EFED601736E2C20A11A56CF532", | |
| salt: "0x0000000000000000000000000000000000000000000000000000000000000000", |
There was a problem hiding this comment.
Will do it in the next PR.
|
TODO: use the testnet wallet for final deployment. |
| "clean": "hardhat clean", | ||
| "compile": "hardhat clean && hardhat compile && npm run artifact-to-abis", | ||
| "verify:ignition": "hardhat ignition verify --include-unrelated-contracts", | ||
| "verify": "hardhat verify", |
There was a problem hiding this comment.
should we keep both script ? or only use verify:ignition as default and rename it to "verify" ?
There was a problem hiding this comment.
I don't think HH Ignition verification is enough. For example, when we upgrade proxies, the new implementation contracts is deployed by upgrades plugin not by HH Ignition meaning that it can't verify it.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
zguesmi
force-pushed
the
feature/sharing-deployment-with-actions
branch
from
5cef1db to
e3c8950
Compare
|
|
|
|
Deploy contracts through a dedicated action.
Steps: